Re: [PATCH 1/8] ide: always auto-tune PIO in legacy VLB host drivers

Re: [PATCH 1/8] ide: always auto-tune PIO in legacy VLB host drivers

[Bodo Eggert]

Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:

|Subject: [PATCH 1/8] ide: always auto-tune PIO in legacy VLB host drivers

AFAIR this isn't safe for bus speeds above 33 MHz, is it?

Re: [PATCH 1/8] ide: always auto-tune PIO in legacy VLB host drivers

[Bartlomiej Zolnierkiewicz]

On Monday 24 March 2008, Bodo Eggert wrote:
> Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> 
> |Subject: [PATCH 1/8] ide: always auto-tune PIO in legacy VLB host drivers
> 
> AFAIR this isn't safe for bus speeds above 33 MHz, is it?

It should be safe as VLB host drivers assume that bus speed is 50 MHz
(so the longest timings are used) if bus speed is not given by user
(using "idebus=" or "ide_core.vlb_clock=")?

Thanks,
Bart

[PATCH 1/8] ide: always auto-tune PIO in legacy VLB host drivers

[Bartlomiej Zolnierkiewicz]

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/legacy/ali14xx.c |    2 +-
 drivers/ide/legacy/dtc2278.c |    3 +--
 drivers/ide/legacy/ht6560b.c |    1 -
 drivers/ide/legacy/qd65xx.c  |    5 +----
 drivers/ide/legacy/umc8672.c |    2 +-
 5 files changed, 4 insertions(+), 9 deletions(-)

Index: b/drivers/ide/legacy/ali14xx.c
===================================================================
--- a/drivers/ide/legacy/ali14xx.c
+++ b/drivers/ide/legacy/ali14xx.c
@@ -202,7 +202,7 @@ static const struct ide_port_info ali14x
 	.name			= DRV_NAME,
 	.chipset		= ide_ali14xx,
 	.port_ops		= &ali14xx_port_ops,
-	.host_flags		= IDE_HFLAG_NO_DMA | IDE_HFLAG_NO_AUTOTUNE,
+	.host_flags		= IDE_HFLAG_NO_DMA,
 	.pio_mask		= ATA_PIO4,
 };
 
Index: b/drivers/ide/legacy/dtc2278.c
===================================================================
--- a/drivers/ide/legacy/dtc2278.c
+++ b/drivers/ide/legacy/dtc2278.c
@@ -101,8 +101,7 @@ static const struct ide_port_info dtc227
 				  IDE_HFLAG_IO_32BIT |
 				  /* disallow ->io_32bit changes */
 				  IDE_HFLAG_NO_IO_32BIT |
-				  IDE_HFLAG_NO_DMA |
-				  IDE_HFLAG_NO_AUTOTUNE,
+				  IDE_HFLAG_NO_DMA,
 	.pio_mask		= ATA_PIO4,
 };
 
Index: b/drivers/ide/legacy/ht6560b.c
===================================================================
--- a/drivers/ide/legacy/ht6560b.c
+++ b/drivers/ide/legacy/ht6560b.c
@@ -340,7 +340,6 @@ static const struct ide_port_info ht6560
 	.port_ops		= &ht6560b_port_ops,
 	.host_flags		= IDE_HFLAG_SERIALIZE | /* is this needed? */
 				  IDE_HFLAG_NO_DMA |
-				  IDE_HFLAG_NO_AUTOTUNE |
 				  IDE_HFLAG_ABUSE_PREFETCH,
 	.pio_mask		= ATA_PIO4,
 };
Index: b/drivers/ide/legacy/qd65xx.c
===================================================================
--- a/drivers/ide/legacy/qd65xx.c
+++ b/drivers/ide/legacy/qd65xx.c
@@ -12,8 +12,6 @@
  * QDI QD6500/QD6580 EIDE controller fast support
  *
  * To activate controller support, use "ide0=qd65xx"
- * To enable tuning, use "hda=autotune hdb=autotune"
- * To enable 2nd channel tuning (qd6580 only), use "hdc=autotune hdd=autotune"
  */
 
 /*
@@ -324,8 +322,7 @@ static const struct ide_port_info qd65xx
 	.name			= DRV_NAME,
 	.chipset		= ide_qd65xx,
 	.host_flags		= IDE_HFLAG_IO_32BIT |
-				  IDE_HFLAG_NO_DMA |
-				  IDE_HFLAG_NO_AUTOTUNE,
+				  IDE_HFLAG_NO_DMA,
 	.pio_mask		= ATA_PIO4,
 };
 
Index: b/drivers/ide/legacy/umc8672.c
===================================================================
--- a/drivers/ide/legacy/umc8672.c
+++ b/drivers/ide/legacy/umc8672.c
@@ -130,7 +130,7 @@ static const struct ide_port_info umc867
 	.name			= DRV_NAME,
 	.chipset		= ide_umc8672,
 	.port_ops		= &umc8672_port_ops,
-	.host_flags		= IDE_HFLAG_NO_DMA | IDE_HFLAG_NO_AUTOTUNE,
+	.host_flags		= IDE_HFLAG_NO_DMA,
 	.pio_mask		= ATA_PIO4,
 };