* [PATCH] libata: cable logic
@ 2008-04-08 15:37 Alan Cox
2008-04-12 4:35 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Alan Cox @ 2008-04-08 15:37 UTC (permalink / raw)
To: akpm, jeff, linux-ide
The cable detect isolation patch inadvertently removed 40 wire short
cable handling. Put it back
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.25-rc8-mm1/drivers/ata/libata-core.c linux-2.6.25-rc8-mm1/drivers/ata/libata-core.c
--- linux.vanilla-2.6.25-rc8-mm1/drivers/ata/libata-core.c 2008-04-08 11:34:51.000000000 +0100
+++ linux-2.6.25-rc8-mm1/drivers/ata/libata-core.c 2008-04-08 12:01:30.000000000 +0100
@@ -4559,6 +4564,10 @@
/* If the controller thinks we are 80 wire, we are */
if (ap->cbl == ATA_CBL_PATA80 || ap->cbl == ATA_CBL_SATA)
return 0;
+ /* If the system is known to be 40 wire short cable (eg laptop),
+ then we allow 80 wire modes even if the drive isn't sure */
+ if (ap->cbl == ATA_CBL_PATA40_SHORT)
+ return 0;
/* If the controller doesn't know we scan
- Note: We look for all 40 wire detects at this point.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libata: cable logic
2008-04-08 15:37 [PATCH] libata: cable logic Alan Cox
@ 2008-04-12 4:35 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-04-12 4:35 UTC (permalink / raw)
To: Alan Cox; +Cc: akpm, linux-ide
Alan Cox wrote:
> The cable detect isolation patch inadvertently removed 40 wire short
> cable handling. Put it back
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.25-rc8-mm1/drivers/ata/libata-core.c linux-2.6.25-rc8-mm1/drivers/ata/libata-core.c
> --- linux.vanilla-2.6.25-rc8-mm1/drivers/ata/libata-core.c 2008-04-08 11:34:51.000000000 +0100
> +++ linux-2.6.25-rc8-mm1/drivers/ata/libata-core.c 2008-04-08 12:01:30.000000000 +0100
> @@ -4559,6 +4564,10 @@
> /* If the controller thinks we are 80 wire, we are */
> if (ap->cbl == ATA_CBL_PATA80 || ap->cbl == ATA_CBL_SATA)
> return 0;
> + /* If the system is known to be 40 wire short cable (eg laptop),
> + then we allow 80 wire modes even if the drive isn't sure */
> + if (ap->cbl == ATA_CBL_PATA40_SHORT)
> + return 0;
> /* If the controller doesn't know we scan
>
> - Note: We look for all 40 wire detects at this point.
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-12 4:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-08 15:37 [PATCH] libata: cable logic Alan Cox
2008-04-12 4:35 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).