* [PATCH] Au1200: IDE driver build fix
@ 2008-04-14 19:03 Sergei Shtylyov
2008-04-15 20:55 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Sergei Shtylyov @ 2008-04-14 19:03 UTC (permalink / raw)
To: bzolnier; +Cc: linux-ide, linux-mips
The driver fails to compile with CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA enabled:
drivers/ide/mips/au1xxx-ide.c: In function `auide_build_dmatable':
drivers/ide/mips/au1xxx-ide.c:256: error: implicit declaration of function
`sg_virt'
drivers/ide/mips/au1xxx-ide.c:275: error: implicit declaration of function
`sg_next'
drivers/ide/mips/au1xxx-ide.c:275: warning: assignment makes pointer from
integer without a cast
Fix this by including <linux/scatterlist.h>. While at it, remove the #include's
without which the driver happily builds.
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
drivers/ide/mips/au1xxx-ide.c | 9 +--------
1 files changed, 1 insertion(+), 8 deletions(-)
Index: linux-2.6/drivers/ide/mips/au1xxx-ide.c
===================================================================
--- linux-2.6.orig/drivers/ide/mips/au1xxx-ide.c
+++ linux-2.6/drivers/ide/mips/au1xxx-ide.c
@@ -32,19 +32,12 @@
#include <linux/kernel.h>
#include <linux/delay.h>
#include <linux/platform_device.h>
-
#include <linux/init.h>
#include <linux/ide.h>
-#include <linux/sysdev.h>
-
-#include <linux/dma-mapping.h>
+#include <linux/scatterlist.h>
-#include "ide-timing.h"
-
-#include <asm/io.h>
#include <asm/mach-au1x00/au1xxx.h>
#include <asm/mach-au1x00/au1xxx_dbdma.h>
-
#include <asm/mach-au1x00/au1xxx_ide.h>
#define DRV_NAME "au1200-ide"
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Au1200: IDE driver build fix
2008-04-14 19:03 [PATCH] Au1200: IDE driver build fix Sergei Shtylyov
@ 2008-04-15 20:55 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-04-15 20:55 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide, linux-mips
On Monday 14 April 2008, Sergei Shtylyov wrote:
> The driver fails to compile with CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA enabled:
>
> drivers/ide/mips/au1xxx-ide.c: In function `auide_build_dmatable':
> drivers/ide/mips/au1xxx-ide.c:256: error: implicit declaration of function
> `sg_virt'
> drivers/ide/mips/au1xxx-ide.c:275: error: implicit declaration of function
> `sg_next'
> drivers/ide/mips/au1xxx-ide.c:275: warning: assignment makes pointer from
> integer without a cast
>
> Fix this by including <linux/scatterlist.h>. While at it, remove the #include's
> without which the driver happily builds.
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-15 21:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-14 19:03 [PATCH] Au1200: IDE driver build fix Sergei Shtylyov
2008-04-15 20:55 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).