linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] [v2] libata-core: set debug logging via module param
@ 2008-04-18 15:52 David Milburn
  0 siblings, 0 replies; only message in thread
From: David Milburn @ 2008-04-18 15:52 UTC (permalink / raw)
  To: jeff; +Cc: linux-ide

Set debug level using ata_logging_level module parameter.

Signed-off-by: David Milburn <dmilburn@redhat.com>
---
 libata-core.c |   14 ++++++--------
 1 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 733eb94..c87f7bd 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -158,6 +158,10 @@ int libata_allow_tpm = 0;
 module_param_named(allow_tpm, libata_allow_tpm, int, 0444);
 MODULE_PARM_DESC(allow_tpm, "Permit the use of TPM commands");
 
+unsigned int ata_logging_level = ATA_MSG_DRV|ATA_MSG_ERR|ATA_MSG_WARN;
+module_param(ata_logging_level, int, 0444);
+MODULE_PARM_DESC(ata_logging_level, "Bit mask of logging levels");
+
 MODULE_AUTHOR("Jeff Garzik");
 MODULE_DESCRIPTION("Library module for ATA devices");
 MODULE_LICENSE("GPL");
@@ -5190,14 +5194,8 @@ struct ata_port *ata_port_alloc(struct ata_host *host)
 	ap->dev = host->dev;
 	ap->last_ctl = 0xFF;
 
-#if defined(ATA_VERBOSE_DEBUG)
-	/* turn on all debugging levels */
-	ap->msg_enable = 0x00FF;
-#elif defined(ATA_DEBUG)
-	ap->msg_enable = ATA_MSG_DRV | ATA_MSG_INFO | ATA_MSG_CTL | ATA_MSG_WARN | ATA_MSG_ERR;
-#else
-	ap->msg_enable = ATA_MSG_DRV | ATA_MSG_ERR | ATA_MSG_WARN;
-#endif
+	/* set debugging level */
+	ap->msg_enable = ata_logging_level;
 
 #ifdef CONFIG_ATA_SFF
 	INIT_DELAYED_WORK(&ap->port_task, ata_pio_task);

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2008-04-18 15:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-18 15:52 [PATCH] [v2] libata-core: set debug logging via module param David Milburn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).