From: Jens Axboe <jens.axboe@oracle.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-scsi@vger.kernel.org, bzolnier@gmail.com,
linux-ide@vger.kernel.org, bharrosh@panasas.com,
James.Bottomley@HansenPartnership.com, agk@redhat.com,
Geert.Uytterhoeven@sonycom.com
Subject: Re: [PATCH 0/6] add large command support to the block layer
Date: Tue, 29 Apr 2008 09:54:24 +0200 [thread overview]
Message-ID: <20080429075424.GF12774@kernel.dk> (raw)
In-Reply-To: <1209140607-28654-1-git-send-email-fujita.tomonori@lab.ntt.co.jp>
On Sat, Apr 26 2008, FUJITA Tomonori wrote:
> This is an updated patchset for large command support to the block
> layer:
>
> http://marc.info/?l=linux-scsi&m=120817127118449&w=2
>
> We rarely handle large commands. So for optimization, a struct request
> still has a static array for a command. rq_init sets rq->cmd pointer
> to the static array. In short, rq_init() does
>
> rq->cmd = rq->__cmd;
>
> So we can access to rq->cmd and rq->cmd_len as before.
>
> This change requires everyone to initialize the request in a proper
> way (that is, just doing a memset() will not work). Now we have
> rq_init() that works for any path so this patchset can cleanly convert
> users of requests on the stack or kmalloced requests to use it (the
> previous patchset does it in a hacky way):
>
> http://marc.info/?l=linux-scsi&m=120911792725876&w=2
>
> This patchset is against Jens' for-linus branch.
>
> #1-#4 patches can be applied via Jens' tree now. #5 patch is for
> IDE. It cleanly can be applied to both Bart's latest quilt tree and
> Jens' tree though Bart's quilt tree has some pending IDE patches. #4
> patch depends on #4. #6 patch depends on #1-#5.
>
> I guess that the easiest way to apply this patchset would be:
>
> 1. Pushing Bart's quilt tree to mainline.
> 2. Rebasing Jens' tree to mainline.
> 3. Pushing this patchset via Jens' tree.
>
> Jens and Bart, let me know if I can do something to make the process
> easier.
>
> Bart, I will try to push the patchset to remove the requests on the
> stack for 2.6.27:
>
> http://marc.info/?l=linux-ide&m=120882410712466&w=2
I've applied all patches to the for-linus branch, it should go up
soonish. If anyone has problems with this, please holler SOON.
--
Jens Axboe
next prev parent reply other threads:[~2008-04-29 7:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-25 16:23 [PATCH 0/6] add large command support to the block layer FUJITA Tomonori
2008-04-25 16:40 ` [PATCH 1/6] block: no need to initialize rq->cmd in prepare_flush_fn hook FUJITA Tomonori
2008-04-25 16:23 ` [PATCH 2/6] block: no need to initialize rq->cmd with blk_get_request FUJITA Tomonori
2008-04-25 16:23 ` [PATCH 3/6] block: rename and export rq_init() FUJITA Tomonori
2008-04-25 16:23 ` [PATCH 4/6] block: use blk_rq_init() to initialize the request FUJITA Tomonori
2008-04-25 16:23 ` [PATCH 5/6] ide: " FUJITA Tomonori
2008-04-25 16:23 ` [PATCH 6/6] block: add large command support FUJITA Tomonori
2008-04-27 11:43 ` Boaz Harrosh
2008-04-27 11:42 ` [PATCH 5/6] ide: use blk_rq_init() to initialize the request Boaz Harrosh
2008-04-27 11:41 ` [PATCH 4/6] block: " Boaz Harrosh
2008-04-27 11:41 ` [PATCH 3/6] block: rename and export rq_init() Boaz Harrosh
2008-04-25 16:45 ` [dm-devel] [PATCH 2/6] block: no need to initialize rq->cmd with blk_get_request James Bottomley
2008-04-25 16:54 ` FUJITA Tomonori
2008-04-25 16:59 ` James Bottomley
2008-04-25 18:35 ` FUJITA Tomonori
2008-04-29 7:54 ` Jens Axboe [this message]
2008-04-29 11:55 ` [PATCH 0/6] add large command support to the block layer Bartlomiej Zolnierkiewicz
2008-04-29 12:32 ` FUJITA Tomonori
2008-04-29 12:37 ` Jens Axboe
2008-04-29 12:45 ` FUJITA Tomonori
2008-04-29 12:46 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080429075424.GF12774@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agk@redhat.com \
--cc=bharrosh@panasas.com \
--cc=bzolnier@gmail.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).