Re: [PATCH] ata: Add Intel SCH PATA support (revised)

[Alek Du <alek.du@intel.com>]

On Tue, 29 Apr 2008 08:14:11 +0800
Alek Du <alek.du@intel.com> wrote:

> > needs to be defined (which will lack .enablebits field but otherwise
> > be identical to DECLARE_ICH_DEV)
> > 
> I do not understand here, where DECLARE_ICH_DEV() used here? I just defined a new sub_type
> sch_pata_100, and inherit most ops from piix instead of cable_detect and prereset. 
>

I see now. I posted a new patch which defined DECLARE_SCH_DEV. Thanks a lot.

> > also seems that piix_cable_detect() should be updated to check for
> > dev->device == PCI_DEVICE_ID_INTEL_SCH_IDE and return ATA_CBL_PATA80
> > (it is OK to use it instead of ATA_CBL_UNK in drivers/ide/ - generic
> > cable detection code won't override drive side cable detection).
> >
> My first version of patch is to modify piix_cable_detect like your way. But Alan suggested
> use this way -- it is much cleaner. And according to my test, return ATA_CBL_UNK do no harm.
> The driver is set to UDMA5 when 80 cable is used.
>  
> > otherwise everything looks good
> > 
> > Thanks,
> > Bart
> 
> Thanks,
> Alek