From mboxrd@z Thu Jan 1 00:00:00 1970 From: FUJITA Tomonori Subject: Re: [PATCH 2/3] ide: set REQ_NOMERGE request flag in ide_do_drive_cmd() Date: Mon, 5 May 2008 22:02:53 +0900 Message-ID: <20080505204334P.tomof@acm.org> References: <200805031514.24727.bzolnier@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from mo10.iij4u.or.jp ([210.138.174.78]:50885 "EHLO mo10.iij4u.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754473AbYEEND4 (ORCPT ); Mon, 5 May 2008 09:03:56 -0400 In-Reply-To: <200805031514.24727.bzolnier@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: bzolnier@gmail.com Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, fujita.tomonori@lab.ntt.co.jp, petkovbb@gmail.com, jens.axboe@oracle.com On Sat, 3 May 2008 15:14:24 +0200 Bartlomiej Zolnierkiewicz wrote: > This is a preparation for converting IDE to use blk_execute_rq(). > > There should be no functional changes caused by this patch. > > Cc: FUJITA Tomonori > Cc: Borislav Petkov > Cc: Jens Axboe > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > drivers/ide/ide-io.c | 2 ++ > 1 file changed, 2 insertions(+) I think that you can drop this since the block layer doesn't check REQ_NOMERGE with the way ide_do_drive_cmd queues requests.