* [PATCH 2/3] ide: set REQ_NOMERGE request flag in ide_do_drive_cmd()
@ 2008-05-03 13:14 Bartlomiej Zolnierkiewicz
2008-05-05 13:02 ` FUJITA Tomonori
0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-05-03 13:14 UTC (permalink / raw)
To: linux-ide; +Cc: linux-kernel, FUJITA Tomonori, Borislav Petkov, Jens Axboe
This is a preparation for converting IDE to use blk_execute_rq().
There should be no functional changes caused by this patch.
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: Borislav Petkov <petkovbb@gmail.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ide-io.c | 2 ++
1 file changed, 2 insertions(+)
Index: b/drivers/ide/ide-io.c
===================================================================
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -1603,6 +1603,8 @@ int ide_do_drive_cmd (ide_drive_t *drive
if (action == ide_preempt || action == ide_head_wait)
where = ELEVATOR_INSERT_FRONT;
+ rq->cmd_flags |= REQ_NOMERGE;
+
spin_lock_irqsave(&ide_lock, flags);
if (action == ide_preempt)
hwgroup->rq = NULL;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] ide: set REQ_NOMERGE request flag in ide_do_drive_cmd()
2008-05-03 13:14 [PATCH 2/3] ide: set REQ_NOMERGE request flag in ide_do_drive_cmd() Bartlomiej Zolnierkiewicz
@ 2008-05-05 13:02 ` FUJITA Tomonori
2008-05-05 16:31 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: FUJITA Tomonori @ 2008-05-05 13:02 UTC (permalink / raw)
To: bzolnier; +Cc: linux-ide, linux-kernel, fujita.tomonori, petkovbb, jens.axboe
On Sat, 3 May 2008 15:14:24 +0200
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> This is a preparation for converting IDE to use blk_execute_rq().
>
> There should be no functional changes caused by this patch.
>
> Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Cc: Borislav Petkov <petkovbb@gmail.com>
> Cc: Jens Axboe <jens.axboe@oracle.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
> drivers/ide/ide-io.c | 2 ++
> 1 file changed, 2 insertions(+)
I think that you can drop this since the block layer doesn't check
REQ_NOMERGE with the way ide_do_drive_cmd queues requests.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] ide: set REQ_NOMERGE request flag in ide_do_drive_cmd()
2008-05-05 13:02 ` FUJITA Tomonori
@ 2008-05-05 16:31 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-05-05 16:31 UTC (permalink / raw)
To: FUJITA Tomonori; +Cc: linux-ide, linux-kernel, petkovbb, jens.axboe
On Monday 05 May 2008, FUJITA Tomonori wrote:
> On Sat, 3 May 2008 15:14:24 +0200
> Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
>
> > This is a preparation for converting IDE to use blk_execute_rq().
> >
> > There should be no functional changes caused by this patch.
> >
> > Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> > Cc: Borislav Petkov <petkovbb@gmail.com>
> > Cc: Jens Axboe <jens.axboe@oracle.com>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > ---
> > drivers/ide/ide-io.c | 2 ++
> > 1 file changed, 2 insertions(+)
>
> I think that you can drop this since the block layer doesn't check
> REQ_NOMERGE with the way ide_do_drive_cmd queues requests.
Yeah, I see now that REQ_NOMERGE only matters for fs requests.
Dropped.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-05 16:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-03 13:14 [PATCH 2/3] ide: set REQ_NOMERGE request flag in ide_do_drive_cmd() Bartlomiej Zolnierkiewicz
2008-05-05 13:02 ` FUJITA Tomonori
2008-05-05 16:31 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).