From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Alek Du <alek.du@intel.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: Add Intel SCH PATA Support
Date: Tue, 6 May 2008 12:44:48 +0100 [thread overview]
Message-ID: <20080506124448.1415c17c@core> (raw)
In-Reply-To: <20080506094131.4bd70c8a@dxy.sh.intel.com>
> + /* no hotplugging support (FIXME) */
> + if (!in_module_init)
> + return -ENODEV;
I see no reason for this check ? AHCI/PIIX sometimes need this because
they rely on BIOS set values [and nobody has fixed it to only check on
those chips]. Your new driver seems clean of such cases.
Alan
next prev parent reply other threads:[~2008-05-06 11:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080505172356.636649e6@dxy.sh.intel.com>
2008-05-05 10:33 ` [PATCH] libata: Add Intel SCH PATA Support Sergei Shtylyov
[not found] ` <20080505224420.44730838@dxy.sh.intel.com>
2008-05-05 15:01 ` Sergei Shtylyov
2008-05-06 1:41 ` Alek Du
2008-05-06 11:44 ` Alan Cox [this message]
2008-05-06 11:50 ` Sergei Shtylyov
2008-05-06 12:04 ` Jeff Garzik
2008-05-06 12:09 ` Jeff Garzik
2008-05-06 13:31 ` again: " Alek Du
2008-05-06 14:18 ` Jeff Garzik
2008-05-06 16:20 ` Bartlomiej Zolnierkiewicz
2008-05-06 15:59 ` Alan Cox
2008-05-07 2:14 ` Alek Du
2008-05-07 17:38 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080506124448.1415c17c@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alek.du@intel.com \
--cc=bzolnier@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).