From mboxrd@z Thu Jan 1 00:00:00 1970 From: Holger Macht Subject: Re: 2.6.25 semantic change in bay handling? Date: Tue, 6 May 2008 20:36:12 +0200 Message-ID: <20080506183612.GE20797@homac> References: <20080505223357.GA2839@srcf.ucam.org> <20080506081347.GA8688@homac> <20080506082110.GA10355@srcf.ucam.org> <48201987.4020009@gmail.com> <20080506084625.GA10817@srcf.ucam.org> <48201C7D.1070303@gmail.com> <20080506091718.GA11617@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx2.suse.de ([195.135.220.15]:60129 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763654AbYEFSeE (ORCPT ); Tue, 6 May 2008 14:34:04 -0400 Content-Disposition: inline In-Reply-To: <20080506091718.GA11617@srcf.ucam.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Matthew Garrett Cc: Tejun Heo , linux-ide@vger.kernel.org, Jeff Garzik Hi Matthew, ( Please TO or CC hmacht@suse.de ! ) >> Just to make clear that we agree on the design, if so, I'll try to provide >> a patch: >> >> 1. Dock event: libata immediately detaches the device >> >> (libata will need another sysfs flag is_on_dock userspace can query) > Hm. I'm not absolutely certain about this. Do we get a bus check > notification after the dock has been removed? If so, I think it ought to > be handled the same way as the internal bay (ie, signal userspace and > let it clean up and destroy the device - if it fails to do so, then > destroy the device when the dock is actually removed, by catching the > bus/device check, calling the _STA method on the bay and destroying the > device if it's present) libata is notified through the dock driver when a dock event occurs, just before the dock driver undocks, giving no time to userspace to clean up. libata doesn't receive an additional acpi bay event. >> 2. Bay event: libata signals a BAY_EVENT through uevent, userspace writes >> 1 to /sys/.../device/delete > In the case of an eject request, yes. In the case of a bus or device > check, we should call _STA and then delete/hotplug the device as > appropriate. Yes. Regards, Holger