From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH] Fixups to ATA ACPI hotplug Date: Tue, 20 May 2008 14:22:17 +0100 Message-ID: <20080520132217.GA5633@srcf.ucam.org> References: <20080505223357.GA2839@srcf.ucam.org> <20080506081347.GA8688@homac> <20080506082110.GA10355@srcf.ucam.org> <48201987.4020009@gmail.com> <20080506092653.GB4378@homac> <20080506093628.GA12469@srcf.ucam.org> <20080519162934.GA15623@srcf.ucam.org> <20080520074442.GA14417@homac> <20080520102038.GA2441@srcf.ucam.org> <20080520131831.GA568@homac> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:46648 "EHLO vavatch.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754735AbYETNWg (ORCPT ); Tue, 20 May 2008 09:22:36 -0400 Content-Disposition: inline In-Reply-To: <20080520131831.GA568@homac> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo , linux-ide@vger.kernel.org, Jeff Garzik , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, May 20, 2008 at 03:18:32PM +0200, Holger Macht wrote: > + if (kobj && !is_dock_event) { > + sprintf(event_string, "BAY_EVENT=%d", event); > + kobject_uevent_env(kobj, KOBJ_CHANGE, envp); I think we want to do the _EJ0 checking before this, otherwise we'll generate two uevents for the same removal on some hardware. Otherwise, looks good. -- Matthew Garrett | mjg59@srcf.ucam.org