From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 14/40] ide-floppy: merge idefloppy_transfer_pc() and idefloppy_transfer_pc1() Date: Tue, 27 May 2008 20:57:42 +0200 Message-ID: <200805272057.42444.bzolnier@gmail.com> References: <20080518185428.5636.77234.sendpatchset@localhost.localdomain> <20080518185633.5636.61364.sendpatchset@localhost.localdomain> <20080521052429.GA2414@gollum.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from mu-out-0910.google.com ([209.85.134.191]:33000 "EHLO mu-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755213AbYEZTXR (ORCPT ); Mon, 26 May 2008 15:23:17 -0400 Received: by mu-out-0910.google.com with SMTP id w8so1646629mue.1 for ; Mon, 26 May 2008 12:23:16 -0700 (PDT) In-Reply-To: <20080521052429.GA2414@gollum.tnic> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: petkovbb@gmail.com Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org On Wednesday 21 May 2008, Borislav Petkov wrote: > On Sun, May 18, 2008 at 08:56:33PM +0200, Bartlomiej Zolnierkiewicz wrote: > > * Check IDEFLOPPY_FLAG_ZIP_DRIVE flag in idefloppy_transfer_pc1() > > and skip idefloppy_transfer_pc2()-phase if the flag is not set. > > > > * Always use idefloppy_transfer_pc1() in idefloppy_issue_pc() > > and remove no longer needed idefloppy_transfer_pc(). > > ... and also probably mv idefloppy_transfer_pc1() to something like > idefloppy_start_transfer_pc() and rename idefloppy_transfer_pc2() to something > more appropriate like e.g. idefloppy_do_transfer_pc() or similar and do away > with those misleading names and probably even the comments are superfluous then. Probably the most intuitive would be to do: idefloppy_transfer_pc1() -> idefloppy_transfer_pc() and idefloppy_transfer_pc2() -> idefloppy_do_transfer_pc() but I don't feel too strong about it and welcome other ideas (preferably in form of patches :). Thanks, Bart