Re: ata_piix on MacBook4,1: fail to startup in a certain situation

Re: ata_piix on MacBook4,1: fail to startup in a certain situation

[MATSUBAYASHI 'Shaolin' Kohji]

At Wed, 28 May 2008 17:13:29 +0900,
Tejun Heo wrote:
> 
> Please post the result of "lspci -nnvvv".  Thanks.

Thanks, I have attached the lspci -nnvvv output far below:


> > At Wed, 28 May 2008 16:51:05 +0900,
> > MATSUBAYASHI 'Shaolin' Kohji wrote:
> >>
> >> Hi, I've been running 2.6.25 kernel with the patch you posted
> >> (cb6716c879ecf49e2af344926c6a476821812061) on newest MacBook4,1
> >> and works very fine except a certain situation.
> >>
> >>
> >> The case I could reproduced is as follows:
> >>
> >> (1) boot kernel 2.6.25 w/ your patch (or 2.6.25.4 which already
> >>     includes your patch), WITH AC ADAPTER PLUGGED
> >> (2) before executing "reboot", UNPLUG AC ADAPTER
> >> (3) then execute "reboot"
> >> (4) system reboots, but stops booting with the following messages:
> >>     ata_piix 0000:00:1f.2: MAP [ P0 P2 P1 P3 ]
> >> (5) then if I plug the AC adapter, system likely to continue booting
> >>     with the following message:
> >>     ata_piix 0000:00:1f.2: SCR access via SIDPR is available but doesn't work
> >> (5a) sometimes system still keep stopping even though I plug the AC adapter
> >>
> >>
> >> By inserting many printk() functions on ata_piix.c,
> >> I confirmed the pause (between 4 and 5) occurs just before
> >> the following line:
> >>
> >>     /* SCR access via SIDPR doesn't work on some configurations.
> >>      * Give it a test drive by inhibiting power save modes which
> >>      * we'll do anyway.
> >>      */
> >>     scontrol = piix_sidpr_read(dev0, SCR_CONTROL);
> >>
> >>
> >> I also confirmed that the following:
> >>
> > 
> > (2a) before executing "poweroff", KEEP AC ADAPTER PLUGGED
> > (3a) then execute "poweroff"
> > (3b) system shuts down, then I UNPLUG AC ADAPTER
> > (4a) press power button to boot, and sometimes stops booting like
> >      the above (4) and sometimes booting fine without any problems


$ sudo /sbin/lspci -nnvvv

00:00.0 Host bridge [0600]: Intel Corporation Mobile PM965/GM965/GL960 Memory Controller Hub [8086:2a00] (rev 03)
	Subsystem: Apple Computer Inc. Unknown device [106b:00a1]
	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort+ >SERR- <PERR-
	Latency: 0
	Capabilities: [e0] Vendor Specific Information

00:02.0 VGA compatible controller [0300]: Intel Corporation Mobile GM965/GL960 Integrated Graphics Controller [8086:2a02] (rev 03) (prog-if 00 [VGA controller])
	Subsystem: Apple Computer Inc. Unknown device [106b:00a1]
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 0
	Interrupt: pin A routed to IRQ 11
	Region 0: Memory at 90100000 (64-bit, non-prefetchable) [size=1M]
	Region 2: Memory at 80000000 (64-bit, prefetchable) [size=256M]
	Region 4: I/O ports at 6110 [size=8]
	Capabilities: [90] Message Signalled Interrupts: Mask- 64bit- Queue=0/0 Enable-
		Address: 00000000  Data: 0000
	Capabilities: [d0] Power Management version 3
		Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
		Status: D0 PME-Enable- DSel=0 DScale=0 PME-
		Bridge: PM- B3+

00:02.1 Display controller [0380]: Intel Corporation Mobile GM965/GL960 Integrated Graphics Controller [8086:2a03] (rev 03)
	Subsystem: Apple Computer Inc. Unknown device [106b:00a1]
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 0
	Region 0: Memory at 90200000 (64-bit, non-prefetchable) [size=1M]
	Capabilities: [d0] Power Management version 3
		Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
		Status: D0 PME-Enable- DSel=0 DScale=0 PME-
		Bridge: PM- B3+

00:1a.0 USB Controller [0c03]: Intel Corporation 82801H (ICH8 Family) USB UHCI Contoller #4 [8086:2834] (rev 03) (prog-if 00 [UHCI])
	Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 0
	Interrupt: pin A routed to IRQ 20
	Region 4: I/O ports at 60c0 [size=32]

00:1a.1 USB Controller [0c03]: Intel Corporation 82801H (ICH8 Family) USB UHCI Controller #5 [8086:2835] (rev 03) (prog-if 00 [UHCI])
	Subsystem: Apple Computer Inc. Unknown device [106b:00a1]
	Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 0
	Interrupt: pin B routed to IRQ 16
	Region 4: I/O ports at 60a0 [size=32]

00:1a.7 USB Controller [0c03]: Intel Corporation 82801H (ICH8 Family) USB2 EHCI Controller #2 [8086:283a] (rev 03) (prog-if 20 [EHCI])
	Subsystem: Apple Computer Inc. Unknown device [106b:00a1]
	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 0
	Interrupt: pin C routed to IRQ 21
	Region 0: Memory at 90704c00 (32-bit, non-prefetchable) [size=1K]
	Capabilities: [50] Power Management version 2
		Flags: PMEClk- DSI- D1- D2- AuxCurrent=375mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
		Status: D0 PME-Enable- DSel=0 DScale=0 PME-
	Capabilities: [58] Debug port

00:1b.0 Audio device [0403]: Intel Corporation 82801H (ICH8 Family) HD Audio Controller [8086:284b] (rev 03)
	Subsystem: Apple Computer Inc. Unknown device [106b:00a1]
	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 0, Cache Line Size: 256 bytes
	Interrupt: pin A routed to IRQ 20
	Region 0: Memory at 90700000 (64-bit, non-prefetchable) [size=16K]
	Capabilities: [50] Power Management version 2
		Flags: PMEClk- DSI- D1- D2- AuxCurrent=55mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
		Status: D0 PME-Enable- DSel=0 DScale=0 PME-
	Capabilities: [60] Message Signalled Interrupts: Mask- 64bit+ Queue=0/0 Enable-
		Address: 0000000000000000  Data: 0000
	Capabilities: [70] Express Unknown type IRQ 0
		Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag-
		Device: Latency L0s <64ns, L1 <1us
		Device: Errors: Correctable- Non-Fatal- Fatal- Unsupported-
		Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop+
		Device: MaxPayload 128 bytes, MaxReadReq 128 bytes
		Link: Supported Speed unknown, Width x0, ASPM unknown, Port 0
		Link: Latency L0s <64ns, L1 <1us
		Link: ASPM Disabled CommClk- ExtSynch-
		Link: Speed unknown, Width x0

00:1c.0 PCI bridge [0604]: Intel Corporation 82801H (ICH8 Family) PCI Express Port 1 [8086:283f] (rev 03) (prog-if 00 [Normal decode])
	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 0, Cache Line Size: 256 bytes
	Bus: primary=00, secondary=01, subordinate=01, sec-latency=0
	I/O behind bridge: 0000f000-00000fff
	Memory behind bridge: 90600000-906fffff
	Prefetchable memory behind bridge: 00000000fff00000-00000000000fffff
	Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort+ <SERR- <PERR-
	BridgeCtl: Parity- SERR- NoISA- VGA- MAbort- >Reset- FastB2B-
	Capabilities: [40] Express Root Port (Slot+) IRQ 0
		Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag-
		Device: Latency L0s unlimited, L1 unlimited
		Device: Errors: Correctable+ Non-Fatal+ Fatal+ Unsupported+
		Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
		Device: MaxPayload 128 bytes, MaxReadReq 128 bytes
		Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port 1
		Link: Latency L0s <1us, L1 <4us
		Link: ASPM Disabled RCB 64 bytes CommClk- ExtSynch-
		Link: Speed 2.5Gb/s, Width x0
		Slot: AtnBtn- PwrCtrl- MRL- AtnInd- PwrInd- HotPlug+ Surpise+
		Slot: Number 0, PowerLimit 6.500000
		Slot: Enabled AtnBtn- PwrFlt- MRL- PresDet- CmdCplt- HPIrq-
		Slot: AttnInd Unknown, PwrInd Unknown, Power-
		Root: Correctable- Non-Fatal- Fatal- PME-
	Capabilities: [80] Message Signalled Interrupts: Mask- 64bit- Queue=0/0 Enable-
		Address: 00000000  Data: 0000
	Capabilities: [90] Subsystem: Gammagraphx, Inc. Unknown device [0000:0000]
	Capabilities: [a0] Power Management version 2
		Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
		Status: D0 PME-Enable- DSel=0 DScale=0 PME-

00:1c.4 PCI bridge [0604]: Intel Corporation 82801H (ICH8 Family) PCI Express Port 5 [8086:2847] (rev 03) (prog-if 00 [Normal decode])
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 0, Cache Line Size: 256 bytes
	Bus: primary=00, secondary=02, subordinate=02, sec-latency=0
	I/O behind bridge: 0000f000-00000fff
	Memory behind bridge: 90500000-905fffff
	Prefetchable memory behind bridge: 0000000090000000-00000000900fffff
	Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort+ <SERR- <PERR-
	BridgeCtl: Parity- SERR- NoISA- VGA- MAbort- >Reset- FastB2B-
	Capabilities: [40] Express Root Port (Slot+) IRQ 0
		Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag-
		Device: Latency L0s unlimited, L1 unlimited
		Device: Errors: Correctable+ Non-Fatal+ Fatal+ Unsupported+
		Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
		Device: MaxPayload 128 bytes, MaxReadReq 128 bytes
		Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port 5
		Link: Latency L0s <256ns, L1 <4us
		Link: ASPM L1 Enabled RCB 64 bytes CommClk+ ExtSynch-
		Link: Speed 2.5Gb/s, Width x1
		Slot: AtnBtn- PwrCtrl- MRL- AtnInd- PwrInd- HotPlug+ Surpise+
		Slot: Number 4, PowerLimit 6.500000
		Slot: Enabled AtnBtn- PwrFlt- MRL- PresDet- CmdCplt- HPIrq-
		Slot: AttnInd Unknown, PwrInd Unknown, Power-
		Root: Correctable- Non-Fatal- Fatal- PME-
	Capabilities: [80] Message Signalled Interrupts: Mask- 64bit- Queue=0/0 Enable-
		Address: 00000000  Data: 0000
	Capabilities: [90] Subsystem: Gammagraphx, Inc. Unknown device [0000:0000]
	Capabilities: [a0] Power Management version 2
		Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
		Status: D0 PME-Enable- DSel=0 DScale=0 PME-

00:1c.5 PCI bridge [0604]: Intel Corporation 82801H (ICH8 Family) PCI Express Port 6 [8086:2849] (rev 03) (prog-if 00 [Normal decode])
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 0, Cache Line Size: 256 bytes
	Bus: primary=00, secondary=03, subordinate=03, sec-latency=0
	I/O behind bridge: 00005000-00005fff
	Memory behind bridge: 90400000-904fffff
	Prefetchable memory behind bridge: 0000000090800000-00000000908fffff
	Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- <SERR- <PERR-
	BridgeCtl: Parity- SERR- NoISA- VGA- MAbort- >Reset- FastB2B-
	Capabilities: [40] Express Root Port (Slot+) IRQ 0
		Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag-
		Device: Latency L0s unlimited, L1 unlimited
		Device: Errors: Correctable+ Non-Fatal+ Fatal+ Unsupported+
		Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
		Device: MaxPayload 128 bytes, MaxReadReq 128 bytes
		Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port 6
		Link: Latency L0s <256ns, L1 <4us
		Link: ASPM L1 Enabled RCB 64 bytes CommClk+ ExtSynch-
		Link: Speed 2.5Gb/s, Width x1
		Slot: AtnBtn- PwrCtrl- MRL- AtnInd- PwrInd- HotPlug+ Surpise+
		Slot: Number 5, PowerLimit 6.500000
		Slot: Enabled AtnBtn- PwrFlt- MRL- PresDet- CmdCplt- HPIrq-
		Slot: AttnInd Unknown, PwrInd Unknown, Power-
		Root: Correctable- Non-Fatal- Fatal- PME-
	Capabilities: [80] Message Signalled Interrupts: Mask- 64bit- Queue=0/0 Enable-
		Address: 00000000  Data: 0000
	Capabilities: [90] Subsystem: Gammagraphx, Inc. Unknown device [0000:0000]
	Capabilities: [a0] Power Management version 2
		Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
		Status: D0 PME-Enable- DSel=0 DScale=0 PME-

00:1d.0 USB Controller [0c03]: Intel Corporation 82801H (ICH8 Family) USB UHCI Controller #1 [8086:2830] (rev 03) (prog-if 00 [UHCI])
	Subsystem: Apple Computer Inc. Unknown device [106b:00a1]
	Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 0
	Interrupt: pin A routed to IRQ 16
	Region 4: I/O ports at 6080 [size=32]

00:1d.1 USB Controller [0c03]: Intel Corporation 82801H (ICH8 Family) USB UHCI Controller #2 [8086:2831] (rev 03) (prog-if 00 [UHCI])
	Subsystem: Apple Computer Inc. Unknown device [106b:00a1]
	Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 0
	Interrupt: pin B routed to IRQ 18
	Region 4: I/O ports at 6060 [size=32]

00:1d.2 USB Controller [0c03]: Intel Corporation 82801H (ICH8 Family) USB UHCI Controller #3 [8086:2832] (rev 03) (prog-if 00 [UHCI])
	Subsystem: Apple Computer Inc. Unknown device [106b:00a1]
	Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 0
	Interrupt: pin C routed to IRQ 21
	Region 4: I/O ports at 6040 [size=32]

00:1d.7 USB Controller [0c03]: Intel Corporation 82801H (ICH8 Family) USB2 EHCI Controller #1 [8086:2836] (rev 03) (prog-if 20 [EHCI])
	Subsystem: Apple Computer Inc. Unknown device [106b:00a1]
	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 0
	Interrupt: pin D routed to IRQ 20
	Region 0: Memory at 90704800 (32-bit, non-prefetchable) [size=1K]
	Capabilities: [50] Power Management version 2
		Flags: PMEClk- DSI- D1- D2- AuxCurrent=375mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
		Status: D0 PME-Enable- DSel=0 DScale=0 PME-
	Capabilities: [58] Debug port

00:1e.0 PCI bridge [0604]: Intel Corporation 82801 Mobile PCI Bridge [8086:2448] (rev f3) (prog-if 01 [Subtractive decode])
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 0
	Bus: primary=00, secondary=04, subordinate=04, sec-latency=32
	I/O behind bridge: 0000f000-00000fff
	Memory behind bridge: 90300000-903fffff
	Prefetchable memory behind bridge: 00000000fff00000-00000000000fffff
	Secondary status: 66MHz- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort+ <SERR- <PERR-
	BridgeCtl: Parity- SERR- NoISA- VGA- MAbort- >Reset- FastB2B-
	Capabilities: [50] Subsystem: Gammagraphx, Inc. Unknown device [0000:0000]

00:1f.0 ISA bridge [0601]: Intel Corporation 82801HEM (ICH8M) LPC Interface Controller [8086:2815] (rev 03)
	Subsystem: Apple Computer Inc. Unknown device [106b:00a1]
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 0
	Capabilities: [e0] Vendor Specific Information

00:1f.1 IDE interface [0101]: Intel Corporation 82801HBM/HEM (ICH8M/ICH8M-E) IDE Controller [8086:2850] (rev 03) (prog-if 8f [Master SecP SecO PriP PriO])
	Subsystem: Apple Computer Inc. Unknown device [106b:00a1]
	Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 0
	Interrupt: pin A routed to IRQ 21
	Region 0: I/O ports at 6108 [size=8]
	Region 1: I/O ports at 6124 [size=4]
	Region 2: I/O ports at 6100 [size=8]
	Region 3: I/O ports at 6120 [size=4]
	Region 4: I/O ports at 60e0 [size=16]

00:1f.2 IDE interface [0101]: Intel Corporation 82801HBM/HEM (ICH8M/ICH8M-E) SATA IDE Controller [8086:2828] (rev 03) (prog-if 8f [Master SecP SecO PriP PriO])
	Subsystem: Apple Computer Inc. Unknown device [106b:00a1]
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 0
	Interrupt: pin B routed to IRQ 18
	Region 0: I/O ports at 60f8 [size=8]
	Region 1: I/O ports at 611c [size=4]
	Region 2: I/O ports at 60f0 [size=8]
	Region 3: I/O ports at 6118 [size=4]
	Region 4: I/O ports at 6020 [size=16]
	Region 5: I/O ports at 4000 [size=16]
	Capabilities: [70] Power Management version 3
		Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot+,D3cold-)
		Status: D0 PME-Enable- DSel=0 DScale=0 PME-

00:1f.3 SMBus [0c05]: Intel Corporation 82801H (ICH8 Family) SMBus Controller [8086:283e] (rev 03)
	Subsystem: Apple Computer Inc. Unknown device [106b:00a1]
	Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Interrupt: pin C routed to IRQ 20
	Region 0: Memory at 90705000 (32-bit, non-prefetchable) [size=256]
	Region 4: I/O ports at efa0 [size=32]

02:00.0 Network controller [0280]: Broadcom Corporation BCM4328 802.11a/b/g/n [14e4:4328] (rev 03)
	Subsystem: Apple Computer Inc. Unknown device [106b:0088]
	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 0, Cache Line Size: 256 bytes
	Interrupt: pin A routed to IRQ 7
	Region 0: Memory at 90500000 (64-bit, non-prefetchable) [size=16K]
	Region 2: Memory at 90000000 (64-bit, prefetchable) [size=1M]
	Capabilities: [40] Power Management version 2
		Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
		Status: D0 PME-Enable- DSel=0 DScale=2 PME-
	Capabilities: [58] Vendor Specific Information
	Capabilities: [e8] Message Signalled Interrupts: Mask- 64bit+ Queue=0/0 Enable-
		Address: 0000000000000000  Data: 0000
	Capabilities: [d0] Express Endpoint IRQ 0
		Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag+
		Device: Latency L0s <4us, L1 unlimited
		Device: AtnBtn- AtnInd- PwrInd-
		Device: Errors: Correctable- Non-Fatal- Fatal- Unsupported-
		Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
		Device: MaxPayload 128 bytes, MaxReadReq 128 bytes
		Link: Supported Speed 2.5Gb/s, Width x1, ASPM unknown, Port 0
		Link: Latency L0s <4us, L1 <64us
		Link: ASPM Disabled RCB 64 bytes CommClk+ ExtSynch-
		Link: Speed 2.5Gb/s, Width x1

03:00.0 Ethernet controller [0200]: Marvell Technology Group Ltd. Marvell Yukon 88E8058 PCI-E Gigabit Ethernet Controller [11ab:436a] (rev 13)
	Subsystem: Marvell Technology Group Ltd. Unknown device [11ab:00ba]
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 0, Cache Line Size: 256 bytes
	Interrupt: pin A routed to IRQ 17
	Region 0: Memory at 90400000 (64-bit, non-prefetchable) [size=16K]
	Region 2: I/O ports at 5000 [size=256]
	Expansion ROM at 90800000 [disabled] [size=128K]
	Capabilities: [48] Power Management version 3
		Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0+,D1+,D2+,D3hot+,D3cold+)
		Status: D0 PME-Enable- DSel=0 DScale=1 PME-
	Capabilities: [50] Vital Product Data
	Capabilities: [5c] Message Signalled Interrupts: Mask- 64bit+ Queue=0/0 Enable-
		Address: 0000000000000000  Data: 0000
	Capabilities: [e0] Express Legacy Endpoint IRQ 0
		Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag-
		Device: Latency L0s unlimited, L1 unlimited
		Device: AtnBtn- AtnInd- PwrInd-
		Device: Errors: Correctable- Non-Fatal- Fatal- Unsupported-
		Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
		Device: MaxPayload 128 bytes, MaxReadReq 2048 bytes
		Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port 0
		Link: Latency L0s <256ns, L1 unlimited
		Link: ASPM L0s L1 Enabled RCB 128 bytes CommClk+ ExtSynch-
		Link: Speed 2.5Gb/s, Width x1

04:03.0 FireWire (IEEE 1394) [0c00]: Agere Systems FW323 [11c1:5811] (rev 61) (prog-if 10 [OHCI])
	Subsystem: Agere Systems FW323 [11c1:5811]
	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- Stepping- SERR- FastB2B+
	Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 248 (3000ns min, 6000ns max), Cache Line Size: 64 bytes
	Interrupt: pin A routed to IRQ 19
	Region 0: Memory at 90300000 (32-bit, non-prefetchable) [size=4K]
	Capabilities: [44] Power Management version 2
		Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0+,D1+,D2+,D3hot+,D3cold-)
		Status: D0 PME-Enable- DSel=0 DScale=0 PME+

Re: ata_piix on MacBook4,1: fail to startup in a certain situation

[Tejun Heo]

[-- Attachment #1: Type: text/plain, Size: 2923 bytes --]

MATSUBAYASHI 'Shaolin' Kohji wrote:
> At Wed, 28 May 2008 17:13:29 +0900,
> Tejun Heo wrote:
>> Please post the result of "lspci -nnvvv".  Thanks.
> 
> Thanks, I have attached the lspci -nnvvv output far below:
> 
> 
>>> At Wed, 28 May 2008 16:51:05 +0900,
>>> MATSUBAYASHI 'Shaolin' Kohji wrote:
>>>> Hi, I've been running 2.6.25 kernel with the patch you posted
>>>> (cb6716c879ecf49e2af344926c6a476821812061) on newest MacBook4,1
>>>> and works very fine except a certain situation.
>>>>
>>>>
>>>> The case I could reproduced is as follows:
>>>>
>>>> (1) boot kernel 2.6.25 w/ your patch (or 2.6.25.4 which already
>>>>     includes your patch), WITH AC ADAPTER PLUGGED
>>>> (2) before executing "reboot", UNPLUG AC ADAPTER
>>>> (3) then execute "reboot"
>>>> (4) system reboots, but stops booting with the following messages:
>>>>     ata_piix 0000:00:1f.2: MAP [ P0 P2 P1 P3 ]
>>>> (5) then if I plug the AC adapter, system likely to continue booting
>>>>     with the following message:
>>>>     ata_piix 0000:00:1f.2: SCR access via SIDPR is available but doesn't work
>>>> (5a) sometimes system still keep stopping even though I plug the AC adapter
>>>>
>>>>
>>>> By inserting many printk() functions on ata_piix.c,
>>>> I confirmed the pause (between 4 and 5) occurs just before
>>>> the following line:
>>>>
>>>>     /* SCR access via SIDPR doesn't work on some configurations.
>>>>      * Give it a test drive by inhibiting power save modes which
>>>>      * we'll do anyway.
>>>>      */
>>>>     scontrol = piix_sidpr_read(dev0, SCR_CONTROL);
>>>>
>>>>
>>>> I also confirmed that the following:
>>>>
>>> (2a) before executing "poweroff", KEEP AC ADAPTER PLUGGED
>>> (3a) then execute "poweroff"
>>> (3b) system shuts down, then I UNPLUG AC ADAPTER
>>> (4a) press power button to boot, and sometimes stops booting like
>>>      the above (4) and sometimes booting fine without any problems
> 
> 
> $ sudo /sbin/lspci -nnvvv
> 00:1f.2 IDE interface [0101]: Intel Corporation 82801HBM/HEM (ICH8M/ICH8M-E) SATA IDE Controller [8086:2828] (rev 03) (prog-if 8f [Master SecP SecO PriP PriO])
> 	Subsystem: Apple Computer Inc. Unknown device [106b:00a1]
> 	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
> 	Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
> 	Latency: 0
> 	Interrupt: pin B routed to IRQ 18
> 	Region 0: I/O ports at 60f8 [size=8]
> 	Region 1: I/O ports at 611c [size=4]
> 	Region 2: I/O ports at 60f0 [size=8]
> 	Region 3: I/O ports at 6118 [size=4]
> 	Region 4: I/O ports at 6020 [size=16]
> 	Region 5: I/O ports at 4000 [size=16]
> 	Capabilities: [70] Power Management version 3
> 		Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot+,D3cold-)
> 		Status: D0 PME-Enable- DSel=0 DScale=0 PME-

Hmmm... What is apple doing with ich8m?  :-(

Does the attached patch fix the problem?

-- 
tejun

[-- Attachment #2: ata_piix-apple.patch --]
[-- Type: text/x-patch, Size: 592 bytes --]

diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index a9027b8..4e90d94 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -251,6 +251,7 @@ static const struct pci_device_id piix_pci_tbl[] = {
 	{ 0x8086, 0x2828, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
 	/* Mobile SATA Controller IDE (ICH8M), Apple */
 	{ 0x8086, 0x2828, 0x106b, 0x00a0, 0, 0, ich8m_apple_sata },
+	{ 0x8086, 0x2828, 0x106b, 0x00a1, 0, 0, ich8m_apple_sata },
 	/* SATA Controller IDE (ICH9) */
 	{ 0x8086, 0x2920, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
 	/* SATA Controller IDE (ICH9) */

Re: ata_piix on MacBook4,1: fail to startup in a certain situation

[MATSUBAYASHI 'Shaolin' Kohji]

At Wed, 28 May 2008 23:23:48 +0900,
Tejun Heo wrote:
> 
> > $ sudo /sbin/lspci -nnvvv
> > 00:1f.2 IDE interface [0101]: Intel Corporation 82801HBM/HEM (ICH8M/ICH8M-E) SATA IDE Controller [8086:2828] (rev 03) (prog-if 8f [Master SecP SecO PriP PriO])
> > 	Subsystem: Apple Computer Inc. Unknown device [106b:00a1]
> > 	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
> > 	Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
> > 	Latency: 0
> > 	Interrupt: pin B routed to IRQ 18
> > 	Region 0: I/O ports at 60f8 [size=8]
> > 	Region 1: I/O ports at 611c [size=4]
> > 	Region 2: I/O ports at 60f0 [size=8]
> > 	Region 3: I/O ports at 6118 [size=4]
> > 	Region 4: I/O ports at 6020 [size=16]
> > 	Region 5: I/O ports at 4000 [size=16]
> > 	Capabilities: [70] Power Management version 3
> > 		Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot+,D3cold-)
> > 		Status: D0 PME-Enable- DSel=0 DScale=0 PME-
> 
> Hmmm... What is apple doing with ich8m?  :-(
> 
> Does the attached patch fix the problem?

Unfortunately no...
With this patch, booting will stop during the execution of
the following lines (in ata_piix.c: piix_init_sidpr()):

        if (pci_resource_start(pdev, PIIX_SIDPR_BAR) == 0 ||
            pci_resource_len(pdev, PIIX_SIDPR_BAR) != PIIX_SIDPR_LEN)
                return;

which might suggest this is not ata_piix related problem I'm afraid...

Again, please note if I keep the AC adapter plugged to MacBook,
there is no such problem happening. It happens only when running with battery.

> -- 
> tejun
> [2 ata_piix-apple.patch <text/x-patch (7bit)>]
> diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
> index a9027b8..4e90d94 100644
> --- a/drivers/ata/ata_piix.c
> +++ b/drivers/ata/ata_piix.c
> @@ -251,6 +251,7 @@ static const struct pci_device_id piix_pci_tbl[] = {
>  	{ 0x8086, 0x2828, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
>  	/* Mobile SATA Controller IDE (ICH8M), Apple */
>  	{ 0x8086, 0x2828, 0x106b, 0x00a0, 0, 0, ich8m_apple_sata },
> +	{ 0x8086, 0x2828, 0x106b, 0x00a1, 0, 0, ich8m_apple_sata },
>  	/* SATA Controller IDE (ICH9) */
>  	{ 0x8086, 0x2920, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
>  	/* SATA Controller IDE (ICH9) */

--
Kohji

Re: ata_piix on MacBook4,1: fail to startup in a certain situation

[Tejun Heo]

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

MATSUBAYASHI 'Shaolin' Kohji wrote:
> Unfortunately no...
> With this patch, booting will stop during the execution of
> the following lines (in ata_piix.c: piix_init_sidpr()):
> 
>         if (pci_resource_start(pdev, PIIX_SIDPR_BAR) == 0 ||
>             pci_resource_len(pdev, PIIX_SIDPR_BAR) != PIIX_SIDPR_LEN)
>                 return;
> 
> which might suggest this is not ata_piix related problem I'm afraid...
> 
> Again, please note if I keep the AC adapter plugged to MacBook,
> there is no such problem happening. It happens only when running with battery.

Hmmm.. That really doesn't make much sense.  Can you please try the
attached one just in case?

Thanks.

-- 
tejun

[-- Attachment #2: ata_piix-apple-1.patch --]
[-- Type: text/x-patch, Size: 867 bytes --]

diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index a9027b8..6c2e907 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -251,6 +251,7 @@ static const struct pci_device_id piix_pci_tbl[] = {
 	{ 0x8086, 0x2828, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
 	/* Mobile SATA Controller IDE (ICH8M), Apple */
 	{ 0x8086, 0x2828, 0x106b, 0x00a0, 0, 0, ich8m_apple_sata },
+	{ 0x8086, 0x2828, 0x106b, 0x00a1, 0, 0, ich8m_apple_sata },
 	/* SATA Controller IDE (ICH9) */
 	{ 0x8086, 0x2920, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
 	/* SATA Controller IDE (ICH9) */
@@ -526,7 +527,7 @@ static struct ata_port_info piix_port_info[] = {
 
 	[ich8m_apple_sata] =
 	{
-		.flags		= PIIX_SATA_FLAGS | PIIX_FLAG_SIDPR,
+		.flags		= PIIX_SATA_FLAGS,
 		.pio_mask	= 0x1f,	/* pio0-4 */
 		.mwdma_mask	= 0x07, /* mwdma0-2 */
 		.udma_mask	= ATA_UDMA6,

Re: ata_piix on MacBook4,1: fail to startup in a certain situation

[MATSUBAYASHI 'Shaolin' Kohji]

At Thu, 29 May 2008 09:23:30 +0900,
Tejun Heo wrote:
> 
> Hmmm.. That really doesn't make much sense.  Can you please try the
> attached one just in case?

Still no luck - I couldn't see any progress even with this patch.
Booting still stops during either of the followings:

        if (pci_resource_start(pdev, PIIX_SIDPR_BAR) == 0 ||
            pci_resource_len(pdev, PIIX_SIDPR_BAR) != PIIX_SIDPR_LEN)
                return;

or

scontrol = piix_sidpr_read(dev0, SCR_CONTROL);

Once the AC Adapter is plugged in, booting continues fine.

--
Kohji

> [2 ata_piix-apple-1.patch <text/x-patch (7bit)>]
> diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
> index a9027b8..6c2e907 100644
> --- a/drivers/ata/ata_piix.c
> +++ b/drivers/ata/ata_piix.c
> @@ -251,6 +251,7 @@ static const struct pci_device_id piix_pci_tbl[] = {
>  	{ 0x8086, 0x2828, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
>  	/* Mobile SATA Controller IDE (ICH8M), Apple */
>  	{ 0x8086, 0x2828, 0x106b, 0x00a0, 0, 0, ich8m_apple_sata },
> +	{ 0x8086, 0x2828, 0x106b, 0x00a1, 0, 0, ich8m_apple_sata },
>  	/* SATA Controller IDE (ICH9) */
>  	{ 0x8086, 0x2920, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
>  	/* SATA Controller IDE (ICH9) */
> @@ -526,7 +527,7 @@ static struct ata_port_info piix_port_info[] = {
>  
>  	[ich8m_apple_sata] =
>  	{
> -		.flags		= PIIX_SATA_FLAGS | PIIX_FLAG_SIDPR,
> +		.flags		= PIIX_SATA_FLAGS,
>  		.pio_mask	= 0x1f,	/* pio0-4 */
>  		.mwdma_mask	= 0x07, /* mwdma0-2 */
>  		.udma_mask	= ATA_UDMA6,

Re: ata_piix on MacBook4,1: fail to startup in a certain situation

[Tejun Heo]

MATSUBAYASHI 'Shaolin' Kohji wrote:
> At Thu, 29 May 2008 09:23:30 +0900,
> Tejun Heo wrote:
>> Hmmm.. That really doesn't make much sense.  Can you please try the
>> attached one just in case?
> 
> Still no luck - I couldn't see any progress even with this patch.
> Booting still stops during either of the followings:
> 
>         if (pci_resource_start(pdev, PIIX_SIDPR_BAR) == 0 ||
>             pci_resource_len(pdev, PIIX_SIDPR_BAR) != PIIX_SIDPR_LEN)
>                 return;
> 
> or
> 
> scontrol = piix_sidpr_read(dev0, SCR_CONTROL);
> 
> Once the AC Adapter is plugged in, booting continues fine.

With the patch applied, control should never reach either of the above
two lines.  Can you please double check?

-- 
tejun

Re: ata_piix on MacBook4,1: fail to startup in a certain situation

[MATSUBAYASHI 'Shaolin' Kohji]

At Thu, 29 May 2008 10:45:18 +0900,
Tejun Heo wrote:
> 
> With the patch applied, control should never reach either of the above
> two lines.  Can you please double check?

I applied the following patch to check where the booting stops at


--- drivers/ata/ata_piix.c.orig	2008-05-29 12:26:18.000000000 +0900
+++ drivers/ata/ata_piix.c	2008-05-29 12:20:19.000000000 +0900
@@ -251,6 +251,7 @@
 	{ 0x8086, 0x2828, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
 	/* Mobile SATA Controller IDE (ICH8M), Apple */
 	{ 0x8086, 0x2828, 0x106b, 0x00a0, 0, 0, ich8m_apple_sata },
+	{ 0x8086, 0x2828, 0x106b, 0x00a1, 0, 0, ich8m_apple_sata },
 	/* SATA Controller IDE (ICH9) */
 	{ 0x8086, 0x2920, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
 	/* SATA Controller IDE (ICH9) */
@@ -526,7 +527,7 @@
 
 	[ich8m_apple_sata] =
 	{
-		.flags		= PIIX_SATA_FLAGS | PIIX_FLAG_SIDPR,
+		.flags		= PIIX_SATA_FLAGS,
 		.pio_mask	= 0x1f,	/* pio0-4 */
 		.mwdma_mask	= 0x07, /* mwdma0-2 */
 		.udma_mask	= ATA_UDMA6,
@@ -1360,6 +1361,8 @@
 	if (!(host->ports[0]->flags & PIIX_FLAG_SIDPR))
 		return;
 
+dev_printk(KERN_INFO, &pdev->dev, "PASSED: checking PIIX_FLAG_SIDPR\n");
+
 	if (pci_resource_start(pdev, PIIX_SIDPR_BAR) == 0 ||
 	    pci_resource_len(pdev, PIIX_SIDPR_BAR) != PIIX_SIDPR_LEN)
 		return;
@@ -1375,6 +1378,8 @@
 	 */
 	scontrol = piix_sidpr_read(dev0, SCR_CONTROL);
 
+dev_printk(KERN_INFO, &pdev->dev, "PASSED: piix_sidpr_read(dev0, SCR_CONTROL)\n");
+
 	/* if IPM is already 3, SCR access is probably working.  Don't
 	 * un-inhibit power save modes as BIOS might have inhibited
 	 * them for a reason.


Then I rebooted without connecting the AC adapter, and the booting
process suspends after the following messages:


  (... snip ...)
  ata_piix 0000:00:1f.2: version 2.12
  ACPI: PCI Interrupt 0000:00:1f.2[B] -> GSI 18 (level, low) -> IRQ 18
  ata_piix 0000:00:1f.2: MAP [ P0 P2 P1 P3 ]
  ata_piix 0000:00:1f.2: PASSED: checking PIIX_FLAG_SIDPR


Waited for about a minute, but the booting still keep suspending.

Once I plug the AC adapter again, booting continues with such messages as:


  ata_piix 0000:00:1f.2: PASSED: piix_sidpr_read(dev0, SCR_CONTROL)
  ACPI: EC: missing confirmations, switch off interrupt mode.
  ata_piix 0000:00:1f.2: SCR access via SIDPR is available but doesn't work
  PCI: Setting latency timer of device 0000:00:1f.2 to 64
  Clocksource tsc unstable (delta = -60927459992 ns)
  scsi0 : ata_piix
  scsi1 : ata_piix
  ata1: SATA max UDMA/133 cmd 0x60f8 ctl 0x611c bmdma 0x6020 irq 18
  ata2: SATA max UDMA/133 cmd 0x60f0 ctl 0x6118 bmdma 0x6028 irq 18
  ata1.00: ATA-8: Hitachi HTS542516K9SA00, BBCAC3GP, max UDMA/133
  ata1.00: 312581808 sectors, multi 16: LBA48 NCQ (depth 0/32)
  ata1.00: configured for UDMA/133
  scsi 0:0:0:0: Direct-Access     ATA      Hitachi HTS54251 BBCA PQ: 0 ANSI: 5
  sd 0:0:0:0: [sda] 312581808 512-byte hardware sectors (160042 MB)
  sd 0:0:0:0: [sda] Write Protect is off
  sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
  sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
  sd 0:0:0:0: [sda] 312581808 512-byte hardware sectors (160042 MB)
  sd 0:0:0:0: [sda] Write Protect is off
  sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
  sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
   sda: sda1 sda2 sda3 sda4
  sd 0:0:0:0: [sda] Attached SCSI disk
  (... snip ...)

--
Kohji

Re: ata_piix on MacBook4,1: fail to startup in a certain situation

[Tejun Heo]

[-- Attachment #1: Type: text/plain, Size: 1894 bytes --]

Thanks for verifying.

MATSUBAYASHI 'Shaolin' Kohji wrote:
> At Thu, 29 May 2008 10:45:18 +0900,
> Tejun Heo wrote:
>> With the patch applied, control should never reach either of the above
>> two lines.  Can you please double check?
> 
> I applied the following patch to check where the booting stops at
> 
> 
> --- drivers/ata/ata_piix.c.orig	2008-05-29 12:26:18.000000000 +0900
> +++ drivers/ata/ata_piix.c	2008-05-29 12:20:19.000000000 +0900
> @@ -251,6 +251,7 @@
>  	{ 0x8086, 0x2828, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
>  	/* Mobile SATA Controller IDE (ICH8M), Apple */
>  	{ 0x8086, 0x2828, 0x106b, 0x00a0, 0, 0, ich8m_apple_sata },
> +	{ 0x8086, 0x2828, 0x106b, 0x00a1, 0, 0, ich8m_apple_sata },

This should make your controller to use type ich8m_apple_sata.

>  	/* SATA Controller IDE (ICH9) */
>  	{ 0x8086, 0x2920, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
>  	/* SATA Controller IDE (ICH9) */
> @@ -526,7 +527,7 @@
>  
>  	[ich8m_apple_sata] =
>  	{
> -		.flags		= PIIX_SATA_FLAGS | PIIX_FLAG_SIDPR,
> +		.flags		= PIIX_SATA_FLAGS,
>  		.pio_mask	= 0x1f,	/* pio0-4 */
>  		.mwdma_mask	= 0x07, /* mwdma0-2 */
>  		.udma_mask	= ATA_UDMA6,

Which doesn't have PIIX_FLAG_SIDPR set.

> @@ -1360,6 +1361,8 @@
>  	if (!(host->ports[0]->flags & PIIX_FLAG_SIDPR))
>  		return;

And triggers this condition and return.

> +dev_printk(KERN_INFO, &pdev->dev, "PASSED: checking PIIX_FLAG_SIDPR\n");
> +
>  	if (pci_resource_start(pdev, PIIX_SIDPR_BAR) == 0 ||
>  	    pci_resource_len(pdev, PIIX_SIDPR_BAR) != PIIX_SIDPR_LEN)
>  		return;

So, it shouldn't get here.  Strange.  Ah... Crap.  Now I see it.
Generic entry for 2828 is above ich8m_apple_sata entry.  I wonder how
this ever worked.  Here's the updated patch.  This is without the SIDPR
change.  If this doesn't work please remove PIIX_FLAG_SIDPR from
ich8m_apple_sata entry and see whether that helps.

Thanks.

-- 
tejun

[-- Attachment #2: ata_piix-apple-2.patch --]
[-- Type: text/x-patch, Size: 912 bytes --]

diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index a9027b8..02d6efe 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -247,10 +247,11 @@ static const struct pci_device_id piix_pci_tbl[] = {
 	{ 0x8086, 0x2820, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
 	/* SATA Controller 2 IDE (ICH8) */
 	{ 0x8086, 0x2825, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_2port_sata },
-	/* Mobile SATA Controller IDE (ICH8M) */
-	{ 0x8086, 0x2828, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
 	/* Mobile SATA Controller IDE (ICH8M), Apple */
 	{ 0x8086, 0x2828, 0x106b, 0x00a0, 0, 0, ich8m_apple_sata },
+	{ 0x8086, 0x2828, 0x106b, 0x00a1, 0, 0, ich8m_apple_sata },
+	/* Mobile SATA Controller IDE (ICH8M) */
+	{ 0x8086, 0x2828, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
 	/* SATA Controller IDE (ICH9) */
 	{ 0x8086, 0x2920, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
 	/* SATA Controller IDE (ICH9) */

Re: ata_piix on MacBook4,1: fail to startup in a certain situation

[MATSUBAYASHI 'Shaolin' Kohji]

[-- Attachment #1: Type: text/plain, Size: 691 bytes --]

At Thu, 29 May 2008 15:09:13 +0900,
Tejun Heo wrote:
> 
> So, it shouldn't get here.  Strange.  Ah... Crap.  Now I see it.
> Generic entry for 2828 is above ich8m_apple_sata entry.  I wonder how
> this ever worked.  Here's the updated patch.  This is without the SIDPR
> change.  If this doesn't work please remove PIIX_FLAG_SIDPR from
> ich8m_apple_sata entry and see whether that helps.

Thanks. Now I see why it did get to that line even with the patch...

Anyway, I confirmed that your newest patch (plus PIIX_FLAG_SIDPR removal)
now works fine both with the AC adapter plugged or unplugged.
So the final patch for this case should be as follows.

Thanks again for your help.

--
Kohji


[-- Attachment #2: ata_piix-apple-3.patch --]
[-- Type: text/plain, Size: 1101 bytes --]

--- linux-2.6.26-rc4/drivers/ata/ata_piix.c.orig	2008-05-29 12:26:18.000000000 +0900
+++ linux-2.6.26-rc4/drivers/ata/ata_piix.c	2008-05-29 17:17:46.000000000 +0900
@@ -247,10 +247,11 @@
 	{ 0x8086, 0x2820, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
 	/* SATA Controller 2 IDE (ICH8) */
 	{ 0x8086, 0x2825, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_2port_sata },
-	/* Mobile SATA Controller IDE (ICH8M) */
-	{ 0x8086, 0x2828, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
 	/* Mobile SATA Controller IDE (ICH8M), Apple */
 	{ 0x8086, 0x2828, 0x106b, 0x00a0, 0, 0, ich8m_apple_sata },
+	{ 0x8086, 0x2828, 0x106b, 0x00a1, 0, 0, ich8m_apple_sata },
+	/* Mobile SATA Controller IDE (ICH8M) */
+	{ 0x8086, 0x2828, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
 	/* SATA Controller IDE (ICH9) */
 	{ 0x8086, 0x2920, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
 	/* SATA Controller IDE (ICH9) */
@@ -526,7 +527,7 @@
 
 	[ich8m_apple_sata] =
 	{
-		.flags		= PIIX_SATA_FLAGS | PIIX_FLAG_SIDPR,
+		.flags		= PIIX_SATA_FLAGS,
 		.pio_mask	= 0x1f,	/* pio0-4 */
 		.mwdma_mask	= 0x07, /* mwdma0-2 */
 		.udma_mask	= ATA_UDMA6,

Re: ata_piix on MacBook4,1: fail to startup in a certain situation

[Tejun Heo]

MATSUBAYASHI 'Shaolin' Kohji wrote:
> At Thu, 29 May 2008 15:09:13 +0900,
> Tejun Heo wrote:
>> So, it shouldn't get here.  Strange.  Ah... Crap.  Now I see it.
>> Generic entry for 2828 is above ich8m_apple_sata entry.  I wonder how
>> this ever worked.  Here's the updated patch.  This is without the SIDPR
>> change.  If this doesn't work please remove PIIX_FLAG_SIDPR from
>> ich8m_apple_sata entry and see whether that helps.
> 
> Thanks. Now I see why it did get to that line even with the patch...
> 
> Anyway, I confirmed that your newest patch (plus PIIX_FLAG_SIDPR removal)
> now works fine both with the AC adapter plugged or unplugged.
> So the final patch for this case should be as follows.

Just to confirm, it doesn't work w/ PIIX_FLAG_SIDPR?

-- 
tejun

Re: ata_piix on MacBook4,1: fail to startup in a certain situation

[MATSUBAYASHI 'Shaolin' Kohji]

At Thu, 29 May 2008 18:10:18 +0900,
Tejun Heo wrote:
> 
> Just to confirm, it doesn't work w/ PIIX_FLAG_SIDPR?

No it doesn't work on my MacBook.
I confirmed that the booting suspended (like always)
with the patch w/ PIIX_FLAG_SIDPR.

--
Kohji

Re: ata_piix on MacBook4,1: fail to startup in a certain situation

[Tejun Heo]

MATSUBAYASHI 'Shaolin' Kohji wrote:
> At Thu, 29 May 2008 18:10:18 +0900,
> Tejun Heo wrote:
>> Just to confirm, it doesn't work w/ PIIX_FLAG_SIDPR?
> 
> No it doesn't work on my MacBook.
> I confirmed that the booting suspended (like always)
> with the patch w/ PIIX_FLAG_SIDPR.

Alright, will submit the patch for #upstream-fixes.

Thanks.

-- 
tejun