From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: RESEND: [PATCH] libata-sff: Fix oops reported in kerneloops.org for pnp devices with no ctl Date: Thu, 29 May 2008 19:38:13 +0100 Message-ID: <20080529193813.4bc0a677@core> References: <20080529161453.24735.805.stgit@core> <20080529190235.258d304e@core> <483EF536.90801@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:40848 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752190AbYE2SxP (ORCPT ); Thu, 29 May 2008 14:53:15 -0400 In-Reply-To: <483EF536.90801@garzik.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: Linus Torvalds , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org On Thu, 29 May 2008 14:25:58 -0400 Jeff Garzik wrote: > Alan Cox wrote: > > maybe_altstatus is crap naming but simply making ata_sff_altstatus fake a > > reply in arbitary cases risks not catching mistakes and could mean we > > don't catch corrupting mistakes which would be very bad indeed. > > Please grep the remaining users, IMO you will find that's not really > true. After your patch no core users remain, only ones in a few > scattered drivers that most likely want your logic (or a > simplified-for-that-controller version thereof). I did check them all and review them and read the documentation right back to the original 1010 controller behaviour. I stand by my comment. Alan