From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Nick Piggin <npiggin@suse.de>
Cc: jgarzik@redhat.com, linux-ide@vger.kernel.org
Subject: Re: patch "libata-sff: Fix oops for pnp devices with no ctl" causes regression
Date: Thu, 5 Jun 2008 10:24:24 +0100 [thread overview]
Message-ID: <20080605102424.0cf56c37@core> (raw)
In-Reply-To: <20080605050923.GD11811@wotan.suse.de>
> And when booting with the commit applied, I instead get a whole lot of
> messages like this (this is the first one, copied by hand):
>
> ata2.00: exception Emask 0x0 SAct 0x0 Serr 0x10000000 action 0x6 frozen
> ata2: SError: { }
> ata2.00: cmd c8/00:02:42:08:20/00:00:00:00:00/e0 tag 0 dma 1024 in
> res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
> ata2.00: status: { DRDY }
> ata2: hard resetting link
> ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300)
> ata2.00: configured for UDMA/133
> ata2: EH complete
Well I've been over the patch twice now and I cannot see a single point
at which the sequence of code that *should* be executed is any different.
Stick wmb();rmb(); (or similar barriers to compiler optimisation and I/O
fencing) at the start and end of your ata_sff_altstatus() and see what
happens, if it suddenly decides to behave or forcing it no inline makes
it behave then that would be useful info.
next prev parent reply other threads:[~2008-06-05 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 5:09 patch "libata-sff: Fix oops for pnp devices with no ctl" causes regression Nick Piggin
2008-06-05 9:24 ` Alan Cox [this message]
2008-06-05 10:05 ` Jeff Garzik
2008-06-05 10:21 ` Nick Piggin
2008-06-05 10:31 ` Nick Piggin
2008-06-05 11:19 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080605102424.0cf56c37@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).