From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: 2.6.26-rc5 DOA on mac g5 Date: Fri, 6 Jun 2008 01:16:19 -0700 Message-ID: <20080606011619.5082606f.akpm@linux-foundation.org> References: <20080605215511.85660cdf.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:45601 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751513AbYFFIQ0 (ORCPT ); Fri, 6 Jun 2008 04:16:26 -0400 In-Reply-To: <20080605215511.85660cdf.akpm@linux-foundation.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: linux-ide@vger.kernel.org, linuxppc-dev@ozlabs.org On Thu, 5 Jun 2008 21:55:11 -0700 Andrew Morton wrote: > Might be a platform thing, might be an ATA thing: OK, I found Hugh's fix. Please let's not release 2.6.27 with a 1000-patch bisect-breaking hole in it. From: Hugh Dickins Fix G5 SATA irq 18: nobody cared, reported on -rc5 by Olaf Hering: fixlet to a57c1bade5a0ee5cd8b74502db9cbebb7f5780b2 libata-sff: Fix oops reported in kerneloops.org for pnp devices with no ctl Signed-off-by: Hugh Dickins Acked-by: Alan Cox Tested-by: Olaf Hering Signed-off-by: Andrew Morton --- drivers/ata/libata-sff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/ata/libata-sff.c~libata-fix-g5-sata-broken-on-rc5 drivers/ata/libata-sff.c --- a/drivers/ata/libata-sff.c~libata-fix-g5-sata-broken-on-rc5 +++ a/drivers/ata/libata-sff.c @@ -278,7 +278,7 @@ static u8 ata_sff_irq_status(struct ata_ return status; } /* Clear INTRQ latch */ - status = ata_sff_check_status(ap); + status = ap->ops->sff_check_status(ap); return status; } _