From: Greg KH <greg@kroah.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Chris Wright <chrisw@sous-sol.org>, Tejun Heo <htejun@gmail.com>,
Theodore Ts'o <tytso@mit.edu>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
Jeff Garzik <jeff@garzik.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
Justin Forbes <jmforbes@linuxtx.org>,
linux-kernel@vger.kernel.org,
Chris Wedgwood <reviews@ml.cw.f00f.org>,
Domenico Andreoli <cavokz@gmail.com>,
IDE/ATA development list <linux-ide@vger.kernel.org>,
Randy Dunlap <rdunlap@xenotime.net>,
Michael Krufky <mkrufky@linuxtv.org>,
matthieu.castet@parrot.com, Chuck Ebbert <cebbert@redhat.com>,
Dave Jones <davej@redhat.com>,
akpm@linux-foundation.org, Chuck Wolber <chuckw@quantumlinux.com>,
stable@kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [stable] [patch 10/50] libata: force hardreset if link is in powersave mode
Date: Fri, 6 Jun 2008 18:57:30 -0700 [thread overview]
Message-ID: <20080607015730.GA15123@kroah.com> (raw)
In-Reply-To: <alpine.LFD.1.10.0806061826420.3473@woody.linux-foundation.org>
On Fri, Jun 06, 2008 at 06:27:15PM -0700, Linus Torvalds wrote:
>
>
> On Fri, 6 Jun 2008, Chris Wright wrote:
> >
> > -stable review patch. If anyone has any objections, please let us know.
> > ---------------------
> >
> > From: Tejun Heo <htejun@gmail.com>
> >
> > Inhibiting link PM mode doesn't bring the link back online if it's
> > already in powersave mode. If SRST is used in these cases, libata EH
> > thinks that the link is offline and fails detection. Force hardreset
> > if link is in powersave mode.
>
> This isn't upstream. Maybe there's some reason it's not needed upstream,
> but it would be nice to know.
To quote Tejun when he sent this patch:
---
Patch for -stable only. Devel branch now uses hardreset by
default so this type of promotion logic isn't necessary anymore.
thanks,
greg k-h
next prev parent reply other threads:[~2008-06-07 1:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080607010215.358296706@sous-sol.org>
2008-06-07 1:02 ` [patch 10/50] libata: force hardreset if link is in powersave mode Chris Wright
2008-06-07 1:27 ` Linus Torvalds
2008-06-07 1:57 ` Greg KH [this message]
2008-06-07 16:51 ` [stable] " Linus Torvalds
2008-06-07 3:14 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080607015730.GA15123@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=cavokz@gmail.com \
--cc=cebbert@redhat.com \
--cc=chrisw@sous-sol.org \
--cc=chuckw@quantumlinux.com \
--cc=davej@redhat.com \
--cc=gregkh@suse.de \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=jmforbes@linuxtx.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthieu.castet@parrot.com \
--cc=mkrufky@linuxtv.org \
--cc=rdunlap@xenotime.net \
--cc=reviews@ml.cw.f00f.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).