From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] palm_bk3710: fix resource management (take 2)
Date: Mon, 16 Jun 2008 22:10:39 +0200 [thread overview]
Message-ID: <200806162210.39943.bzolnier@gmail.com> (raw)
In-Reply-To: <200806162351.07566.sshtylyov@ru.mvista.com>
On Monday 16 June 2008, Sergei Shtylyov wrote:
> The driver expected a *virtual* address in the IDE platform device's memory
> resource and didn't request the memory region for the register block. Fix this
> taking into account the fact that DaVinci SoC devices are fixed-mapped to the
> virtual memory early and we can get their virtual addresses using IO_ADDRESS()
> macro, not having to call ioremap()...
>
> While at it, also do some cosmetic changes...
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> ---
> Argh! I have finally run checkpatch.pl and it detected some whitespace damage.
> And of course, I then re-sent it without fixing that!
> So, here's take 2 of that stupid patch for real now. Sorry for the mess... :-<
I've already fixed it while applying "take 1" but I was too lazy to
mention it (not that single " " removal is worth mentioning)... :)
[ However please integrate checkpatch.pl into your workflow... ]
next prev parent reply other threads:[~2008-06-16 20:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 19:51 [PATCH] palm_bk3710: fix resource management (take 2) Sergei Shtylyov
2008-06-16 20:10 ` Bartlomiej Zolnierkiewicz [this message]
2008-06-16 22:35 ` Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2008-06-16 19:48 Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806162210.39943.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).