Re: [PATCH] ide: endian annotations in ide-floppy.c

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Thursday 19 June 2008, Harvey Harrison wrote:
> On Thu, 2008-06-19 at 00:34 +0100, Al Viro wrote:
> > On Wed, Jun 18, 2008 at 03:57:35PM -0700, Harvey Harrison wrote:
> > > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > > ---
> > >  drivers/ide/ide-floppy.c |   16 ++++++++--------
> > >  1 files changed, 8 insertions(+), 8 deletions(-)
> > > 
> > > diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
> > > index f05fbc2..cba39fa 100644
> > > --- a/drivers/ide/ide-floppy.c
> > > +++ b/drivers/ide/ide-floppy.c
> > > @@ -921,10 +921,10 @@ static int ide_floppy_get_flexible_disk_page(ide_drive_t *drive)
> > >  	set_disk_ro(floppy->disk, floppy->wp);
> > >  	page = &pc.buf[8];
> > >  
> > > -	transfer_rate = be16_to_cpu(*(u16 *)&pc.buf[8 + 2]);
> > > -	sector_size   = be16_to_cpu(*(u16 *)&pc.buf[8 + 6]);
> > > -	cyls          = be16_to_cpu(*(u16 *)&pc.buf[8 + 8]);
> > > -	rpm           = be16_to_cpu(*(u16 *)&pc.buf[8 + 28]);
> > > +	transfer_rate = be16_to_cpup((__be16 *)&pc.buf[8 + 2]);
> > > +	sector_size   = be16_to_cpup((__be16 *)&pc.buf[8 + 6]);
> > > +	cyls          = be16_to_cpup((__be16 *)&pc.buf[8 + 8]);
> > > +	rpm           = be16_to_cpup((__be16 *)&pc.buf[8 + 28]);
> > 
> > Pointless, IMO - just s/u16/__be16/ in the above.
> 
> The (admittedly) small reason I did it this way is that some arches do
> have a more efficient pointer version.  Not that they use this code, but
> in principle that's why I used the pointer version.

this indeed seems to result in (tiny) improvement on x86-32:

   text    data     bss     dec     hex filename
   7377     196       0    7573    1d95 drivers/ide/ide-floppy.o.before
   7370     196       0    7566    1d8e drivers/ide/ide-floppy.o.after

thus I applied it as it is