From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: linux-ide@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 10/18] ide: change order of register access in ide_config_drive_speed()
Date: Fri, 20 Jun 2008 23:34:31 +0200 [thread overview]
Message-ID: <20080620213431.13202.79378.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20080620213323.13202.71450.sendpatchset@localhost.localdomain>
Write ATA Feature register before ATA Sector Count register as
a preparation to use ->tf_load in ide_config_drive_speed().
This change shouldn't affect anything (just an usual paranoia).
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ide-iops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/drivers/ide/ide-iops.c
===================================================================
--- a/drivers/ide/ide-iops.c
+++ b/drivers/ide/ide-iops.c
@@ -828,8 +828,8 @@ int ide_config_drive_speed(ide_drive_t *
SELECT_MASK(drive, 0);
udelay(1);
hwif->set_irq(hwif, 0);
- hwif->OUTB(speed, io_ports->nsect_addr);
hwif->OUTB(SETFEATURES_XFER, io_ports->feature_addr);
+ hwif->OUTB(speed, io_ports->nsect_addr);
hwif->exec_command(hwif, WIN_SETFEATURES);
if (drive->quirk_list == 2)
hwif->set_irq(hwif, 1);
next prev parent reply other threads:[~2008-06-20 21:32 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 21:33 [PATCH 01/18] ide: add ->read_sff_dma_status method Bartlomiej Zolnierkiewicz
2008-06-20 21:33 ` [PATCH 02/18] ide: use I/O ops directly in ide-dma.c Bartlomiej Zolnierkiewicz
2008-09-08 15:49 ` Sergei Shtylyov
2008-06-20 21:33 ` [PATCH 03/18] ide: remove ->dma_{status,command} fields from ide_hwif_t Bartlomiej Zolnierkiewicz
2008-06-20 21:33 ` [PATCH 04/18] ide: remove ide_setup_dma() Bartlomiej Zolnierkiewicz
2008-06-20 22:03 ` Sergei Shtylyov
2008-06-21 19:06 ` Bartlomiej Zolnierkiewicz
2008-06-21 19:29 ` Sergei Shtylyov
2008-08-21 17:16 ` Sergei Shtylyov
2008-08-21 17:56 ` Sergei Shtylyov
2008-06-20 21:33 ` [PATCH 05/18] ide: factor out simplex handling from ide_pci_dma_base() Bartlomiej Zolnierkiewicz
2008-06-20 21:34 ` [PATCH 06/18] ide: add ->exec_command method Bartlomiej Zolnierkiewicz
2008-06-20 21:34 ` [PATCH 07/18] ide: add ->read_status method Bartlomiej Zolnierkiewicz
2008-06-20 21:34 ` [PATCH 08/18] ide: add ->read_altstatus method Bartlomiej Zolnierkiewicz
2008-06-20 21:34 ` [PATCH 09/18] ide: add ->set_irq method Bartlomiej Zolnierkiewicz
2008-10-15 12:20 ` Sergei Shtylyov
2008-10-15 18:22 ` Bartlomiej Zolnierkiewicz
2008-10-15 21:22 ` Sergei Shtylyov
2008-06-20 21:34 ` Bartlomiej Zolnierkiewicz [this message]
2008-06-20 21:34 ` [PATCH 11/18] ide: use ->tf_load in ide_config_drive_speed() Bartlomiej Zolnierkiewicz
2008-06-20 21:34 ` [PATCH 12/18] ide: use ->tf_load in actual_try_to_identify() Bartlomiej Zolnierkiewicz
2008-06-20 23:14 ` Sergei Shtylyov
2008-06-21 19:10 ` Bartlomiej Zolnierkiewicz
2008-06-20 21:34 ` [PATCH 13/18] ide: use ->tf_load in SELECT_DRIVE() Bartlomiej Zolnierkiewicz
2009-02-15 20:25 ` Sergei Shtylyov
2009-02-16 0:08 ` Sergei Shtylyov
2009-02-16 11:50 ` Sergei Shtylyov
2009-02-16 21:51 ` Bartlomiej Zolnierkiewicz
2009-02-17 1:04 ` Sergei Shtylyov
2009-02-17 14:43 ` Bartlomiej Zolnierkiewicz
2009-02-17 15:32 ` Sergei Shtylyov
2009-03-04 15:43 ` Sergei Shtylyov
2009-02-17 12:23 ` Sergei Shtylyov
2009-02-17 15:13 ` Sergei Shtylyov
2008-06-20 21:34 ` [PATCH 14/18] ide: use ->tf_read in ide_read_error() Bartlomiej Zolnierkiewicz
2009-02-15 23:21 ` Sergei Shtylyov
2009-02-16 12:13 ` Sergei Shtylyov
2009-02-16 12:25 ` Sergei Shtylyov
2009-02-16 21:17 ` Bartlomiej Zolnierkiewicz
2009-02-17 0:14 ` Sergei Shtylyov
2009-02-17 0:50 ` Sergei Shtylyov
2008-06-20 21:35 ` [PATCH 15/18] ide: add ide_read_device() helper Bartlomiej Zolnierkiewicz
2008-06-20 21:35 ` [PATCH 16/18] ide: add ide_read_ireason() helper Bartlomiej Zolnierkiewicz
2008-06-20 21:35 ` [PATCH 17/18] ide: add ide_read_bcount_and_ireason() helper Bartlomiej Zolnierkiewicz
2008-06-20 21:35 ` [PATCH 18/18] ide: remove ->INB, ->OUTB and ->OUTBSYNC methods Bartlomiej Zolnierkiewicz
2008-09-03 13:19 ` [PATCH 01/18] ide: add ->read_sff_dma_status method Sergei Shtylyov
2008-09-03 18:13 ` Bartlomiej Zolnierkiewicz
2008-09-07 18:15 ` Sergei Shtylyov
2008-09-07 18:49 ` Sergei Shtylyov
2008-09-07 19:23 ` Bartlomiej Zolnierkiewicz
2008-09-07 22:26 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080620213431.13202.79378.sendpatchset@localhost.localdomain \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).