* [PATCH 3/4] ide: filter out invalid transfer mode values in set_xfer_rate()
@ 2008-06-21 19:20 Bartlomiej Zolnierkiewicz
2008-06-21 19:38 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-06-21 19:20 UTC (permalink / raw)
To: linux-ide; +Cc: linux-kernel, Sergei Shtylyov
Filter out invalid transfer mode values (0x02-0x07) in write handler
for obsoleted /proc/ide/hd?/settings:current_speed setting.
While at it:
* Use XFER_UDMA_6 define.
Suggested-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
Sergei, IIRC that it is what you were suggesting some time ago.
drivers/ide/ide-proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/drivers/ide/ide-proc.c
===================================================================
--- a/drivers/ide/ide-proc.c
+++ b/drivers/ide/ide-proc.c
@@ -345,7 +345,7 @@ static int set_xfer_rate (ide_drive_t *d
ide_task_t task;
int err;
- if (arg < 0 || arg > 70)
+ if (arg < 0 || (arg > 1 && arg < XFER_PIO_0) || arg > XFER_UDMA_6)
return -EINVAL;
memset(&task, 0, sizeof(task));
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/4] ide: filter out invalid transfer mode values in set_xfer_rate()
2008-06-21 19:20 [PATCH 3/4] ide: filter out invalid transfer mode values in set_xfer_rate() Bartlomiej Zolnierkiewicz
@ 2008-06-21 19:38 ` Sergei Shtylyov
2008-06-21 19:57 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2008-06-21 19:38 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide, linux-kernel
Hello.
Bartlomiej Zolnierkiewicz wrote:
> Filter out invalid transfer mode values (0x02-0x07) in write handler
> for obsoleted /proc/ide/hd?/settings:current_speed setting.
>
> While at it:
>
> * Use XFER_UDMA_6 define.
>
> Suggested-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
> Sergei, IIRC that it is what you were suggesting some time ago.
>
Maybe I did. :-) But I don't see what that gives to us now...
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/4] ide: filter out invalid transfer mode values in set_xfer_rate()
2008-06-21 19:38 ` Sergei Shtylyov
@ 2008-06-21 19:57 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-06-21 19:57 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide, linux-kernel
On Saturday 21 June 2008, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
> > Filter out invalid transfer mode values (0x02-0x07) in write handler
> > for obsoleted /proc/ide/hd?/settings:current_speed setting.
> >
> > While at it:
> >
> > * Use XFER_UDMA_6 define.
> >
> > Suggested-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > ---
> > Sergei, IIRC that it is what you were suggesting some time ago.
> >
>
> Maybe I did. :-) But I don't see what that gives to us now...
One free IDE_HFLAG_ host flag (in patch #4/4)!! :)
[ I just went through backlog of lower-prio TODO items. ]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-06-21 19:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-21 19:20 [PATCH 3/4] ide: filter out invalid transfer mode values in set_xfer_rate() Bartlomiej Zolnierkiewicz
2008-06-21 19:38 ` Sergei Shtylyov
2008-06-21 19:57 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).