linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: Andreas Schwab <schwab@suse.de>
Cc: Tejun Heo <tj@kernel.org>,
	kernel list <linux-kernel@vger.kernel.org>,
	benh@kernel.crashing.org, jgarzik@pobox.com,
	IDE/ATA development list <linux-ide@vger.kernel.org>,
	Trivial patch monkey <trivial@kernel.org>
Subject: Re: sata_svw data corruption, strange problems
Date: Mon, 23 Jun 2008 10:53:38 +0200	[thread overview]
Message-ID: <20080623085338.GE1850@elf.ucw.cz> (raw)
In-Reply-To: <je63s0sfxv.fsf@sykes.suse.de>

On Mon 2008-06-23 10:39:40, Andreas Schwab wrote:
> Pavel Machek <pavel@suse.cz> writes:
> 
> > +	   controller, the controller could hang. In other cases it
> > +	   could return partial data returning in data
> > +	   corruption. This problem has been seen in PPC systems and
> 
> s/returning/resulting/ ?

Fix thinko in sata_svw comment.

Signed-off-by: Pavel Machek <pavel@suse.cz>

diff --git a/drivers/ata/sata_svw.c b/drivers/ata/sata_svw.c
index fb13b82..d6313f1 100644
--- a/drivers/ata/sata_svw.c
+++ b/drivers/ata/sata_svw.c
@@ -269,7 +269,7 @@ static void k2_bmdma_start_mmio(struct a
 	   would become confused as to what to do with the data.  In
 	   the worst case when all the data is returned back to the
 	   controller, the controller could hang. In other cases it
-	   could return partial data returning in data
+	   could return partial data resulting in data
 	   corruption. This problem has been seen in PPC systems and
 	   can also appear on an system with very fast disks, where
 	   the SATA controller is sitting behind a number of bridges,


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2008-06-23  8:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080617093602.GA28140@elf.ucw.cz>
2008-06-23  0:37 ` sata_svw data corruption, strange problems Tejun Heo
2008-06-23  8:20   ` Pavel Machek
2008-06-23  8:22     ` Tejun Heo
2008-06-23  8:39     ` Andreas Schwab
2008-06-23  8:53       ` Pavel Machek [this message]
2008-06-23  8:56         ` Tejun Heo
2008-06-23  9:01           ` Pavel Machek
2008-06-23  9:04             ` Benjamin Herrenschmidt
2008-06-23  9:26               ` Pavel Machek
2008-06-23  9:48               ` Tejun Heo
2008-06-23  9:42                 ` Alan Cox
2008-06-23 10:23                   ` Benjamin Herrenschmidt
2008-06-23 13:05                   ` Tejun Heo
2008-06-27  6:41             ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080623085338.GE1850@elf.ucw.cz \
    --to=pavel@suse.cz \
    --cc=benh@kernel.crashing.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwab@suse.de \
    --cc=tj@kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).