* [PATCH] drivers/ide/ide-tape.c: remove double kfree
@ 2008-06-28 22:34 Darren Jenkins\
2008-06-29 16:26 ` Borislav Petkov
0 siblings, 1 reply; 3+ messages in thread
From: Darren Jenkins\ @ 2008-06-28 22:34 UTC (permalink / raw)
To: kernel Janitors, LKML, linux-ide, gadio
G'day people,
Coverity CID: 2336 USE_AFTER_FREE
drivers/ide/ide-tape.c ide_tape_kfree_buffer() double free's a pointer
(hint freed by an alias in first outer loop).
This patch simply removes the superfluous kfree().
Signed-off-by: Darren Jenkins <darrenrjenkins@gmailcom>
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 1e1f263..86164be 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -600,7 +600,6 @@ static void ide_tape_kfree_buffer(idetape_tape_t *tape)
bh = bh->b_reqnext;
kfree(prev_bh);
}
- kfree(tape->merge_bh);
}
static int idetape_end_request(ide_drive_t *drive, int uptodate, int nr_sects)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/ide/ide-tape.c: remove double kfree
2008-06-28 22:34 [PATCH] drivers/ide/ide-tape.c: remove double kfree Darren Jenkins\
@ 2008-06-29 16:26 ` Borislav Petkov
2008-06-30 20:45 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Borislav Petkov @ 2008-06-29 16:26 UTC (permalink / raw)
To: Darren Jenkins, bzolnier; +Cc: kernel Janitors, LKML, linux-ide, gadio
Hi Bart,
in case you haven't picked that one up already...
On Sun, Jun 29, 2008 at 08:34:34AM +1000, Darren Jenkins" wrote:
> G'day people,
>
>
> Coverity CID: 2336 USE_AFTER_FREE
>
> drivers/ide/ide-tape.c ide_tape_kfree_buffer() double free's a pointer
> (hint freed by an alias in first outer loop).
> This patch simply removes the superfluous kfree().
>
>
>
> Signed-off-by: Darren Jenkins <darrenrjenkins@gmailcom>
Acked-by: Borislav Petkov <petkovbb@gmail.com>
>
>
> diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
> index 1e1f263..86164be 100644
> --- a/drivers/ide/ide-tape.c
> +++ b/drivers/ide/ide-tape.c
> @@ -600,7 +600,6 @@ static void ide_tape_kfree_buffer(idetape_tape_t *tape)
> bh = bh->b_reqnext;
> kfree(prev_bh);
> }
> - kfree(tape->merge_bh);
> }
>
> static int idetape_end_request(ide_drive_t *drive, int uptodate, int nr_sects)
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Regards/Gruß,
Boris.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/ide/ide-tape.c: remove double kfree
2008-06-29 16:26 ` Borislav Petkov
@ 2008-06-30 20:45 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-06-30 20:45 UTC (permalink / raw)
To: petkovbb; +Cc: Darren Jenkins, kernel Janitors, LKML, linux-ide, gadio
On Sunday 29 June 2008, Borislav Petkov wrote:
> Hi Bart,
>
> in case you haven't picked that one up already...
>
> On Sun, Jun 29, 2008 at 08:34:34AM +1000, Darren Jenkins" wrote:
> > G'day people,
> >
> >
> > Coverity CID: 2336 USE_AFTER_FREE
> >
> > drivers/ide/ide-tape.c ide_tape_kfree_buffer() double free's a pointer
> > (hint freed by an alias in first outer loop).
> > This patch simply removes the superfluous kfree().
> >
> >
> >
> > Signed-off-by: Darren Jenkins <darrenrjenkins@gmailcom>
> Acked-by: Borislav Petkov <petkovbb@gmail.com>
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-06-30 21:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-28 22:34 [PATCH] drivers/ide/ide-tape.c: remove double kfree Darren Jenkins\
2008-06-29 16:26 ` Borislav Petkov
2008-06-30 20:45 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).