[PATCH] ide: disable drive interrupts in ide_driveid_update()

[PATCH] ide: disable drive interrupts in ide_driveid_update()

[Sergei Shtylyov]

From: Mikhail Cherkashin <mcherkashin@ru.mvista.com>

Since ide_driveid_update() uses polling to execute the IDENTIFY DEVICE command
but clears nIEN bit in the control register and doesn't mask the IDE interrupt,
the latter does happen and lead to the corresponding message to appear:

ide0: unexpected interrupt, status=0x58, count=1

when e.g. running hdparm with option -X with a non-PCI IDE driver...

Signed-off-by: Mikhail Cherkashin <mcherkashin@ru.mvista.com>
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

---
No attempt is made to respect the drive's quirkiness which is probably not
correct but the 'drive->quirk_list' matter is somewhat confusing...

 drivers/ide/ide-iops.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/ide/ide-iops.c b/drivers/ide/ide-iops.c
index 0daf923..c2dd20a 100644
--- a/drivers/ide/ide-iops.c
+++ b/drivers/ide/ide-iops.c
@@ -689,7 +689,7 @@ int ide_driveid_update(ide_drive_t *drive)
 	 */
 
 	SELECT_MASK(drive, 1);
-	ide_set_irq(drive, 1);
+	ide_set_irq(drive, 0);
 	msleep(50);
 	hwif->OUTBSYNC(drive, WIN_IDENTIFY, hwif->io_ports.command_addr);
 	timeout = jiffies + WAIT_WORSTCASE;

Re: [PATCH] ide: disable drive interrupts in ide_driveid_update()

[Bartlomiej Zolnierkiewicz]

On Wednesday 09 July 2008, Sergei Shtylyov wrote:
> From: Mikhail Cherkashin <mcherkashin@ru.mvista.com>
> 
> Since ide_driveid_update() uses polling to execute the IDENTIFY DEVICE command
> but clears nIEN bit in the control register and doesn't mask the IDE interrupt,
> the latter does happen and lead to the corresponding message to appear:
> 
> ide0: unexpected interrupt, status=0x58, count=1
> 
> when e.g. running hdparm with option -X with a non-PCI IDE driver...
> 
> Signed-off-by: Mikhail Cherkashin <mcherkashin@ru.mvista.com>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

applied