From: Ingo Molnar <mingo@elte.hu>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
grundler@parisc-linux.org, tglx@linutronix.de, jgarzik@pobox.com,
linux-ide@vger.kernel.org, suresh.b.siddha@intel.com,
benh@kernel.crashing.org, jbarnes@virtuousgeek.org,
rdunlap@xenotime.net, mtk.manpages@gmail.com,
ebiederm@xmission.com, Matthew Wilcox <willy@linux.intel.com>,
Yinghai Lu <yhlu.kernel@gmail.com>
Subject: Re: [PATCH 6/6] x86-64: Support for multiple MSIs
Date: Sat, 12 Jul 2008 07:54:44 +0200 [thread overview]
Message-ID: <20080712055444.GA13420@elte.hu> (raw)
In-Reply-To: <1215811018-15270-6-git-send-email-matthew@wil.cx>
* Matthew Wilcox <matthew@wil.cx> wrote:
> Add support for allocating an aligned block of interrupt vectors.
> Allow interrupts to have up to 32 subchannels. Implement the
> arch_setup_msi_irqs() and arch_teardown_msi_irqs() interfaces.
>
> Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
> ---
> arch/x86/kernel/io_apic_64.c | 221 +++++++++++++++++++++++++++++++++++------
> arch/x86/kernel/irq_64.c | 2 +-
> include/asm-x86/irq_64.h | 2 +
> 3 files changed, 191 insertions(+), 34 deletions(-)
hm, please implement this symmetrically on 64-bit and 32-bit as well.
That will need more IRQ infrastructure changes but that should be OK as
it will reduce the gap between the 32-bit and 64-bit side instead of
widening it. A good starting point would be to unify/generalize the IRQ
vector allocators. (and that would get most of what you need for
multi-vector MSI)
Ingo
next prev parent reply other threads:[~2008-07-12 5:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 21:16 Multiple MSI, take 4 Matthew Wilcox
2008-07-11 21:16 ` [PATCH 1/6] Allow a small amount of data to be stored with the interrupt number Matthew Wilcox
2008-07-11 21:16 ` [PATCH 2/6] PCI MSI: Replace 'type' with 'is_msix' Matthew Wilcox
2008-07-11 21:16 ` [PATCH 3/6] PCI MSI: Add support for multiple messages Matthew Wilcox
2008-07-11 21:16 ` [PATCH 4/6] Rewrite MSI-HOWTO Matthew Wilcox
2008-07-11 21:16 ` [PATCH 5/6] AHCI: Request multiple MSIs Matthew Wilcox
2008-07-11 21:16 ` [PATCH 6/6] x86-64: Support for " Matthew Wilcox
2008-07-12 5:54 ` Ingo Molnar [this message]
2008-07-12 16:30 ` Matthew Wilcox
2008-07-12 18:44 ` Yinghai Lu
2008-07-12 7:37 ` Multiple MSI, take 4 Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080712055444.GA13420@elte.hu \
--to=mingo@elte.hu \
--cc=benh@kernel.crashing.org \
--cc=ebiederm@xmission.com \
--cc=grundler@parisc-linux.org \
--cc=jbarnes@virtuousgeek.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mtk.manpages@gmail.com \
--cc=rdunlap@xenotime.net \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=willy@linux.intel.com \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).