* [PATCH] ide: it821x in pass-through mode segfaults in 2.6.26-stable
@ 2008-07-14 19:11 Dimitri Gorokhovik
2008-07-16 15:02 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Dimitri Gorokhovik @ 2008-07-14 19:11 UTC (permalink / raw)
To: linux-ide, bzolnier; +Cc: linux-kernel, stable
(Let me know if you need the kernel config for this.)
---
The driver of ITE8212 in pass-through mode (it8212.noraid=1 on cmndline)
attempts to use the field `.dma_host_set' of the struct ide_dma_ops in
`ide_config_drive_speed' which is set to NULL by default.
So give a value to all fields of the struct ide_dma_ops.
---
diff --git a/drivers/ide/pci/it821x.c b/drivers/ide/pci/it821x.c
index 6ab0411..cbf6472 100644
--- a/drivers/ide/pci/it821x.c
+++ b/drivers/ide/pci/it821x.c
@@ -512,8 +512,14 @@ static void __devinit it821x_quirkproc(ide_drive_t *drive)
}
static struct ide_dma_ops it821x_pass_through_dma_ops = {
+ .dma_host_set = ide_dma_host_set,
+ .dma_setup = ide_dma_setup,
+ .dma_exec_cmd = ide_dma_exec_cmd,
.dma_start = it821x_dma_start,
.dma_end = it821x_dma_end,
+ .dma_test_irq = ide_dma_test_irq,
+ .dma_timeout = ide_dma_timeout,
+ .dma_lost_irq = ide_dma_lost_irq,
};
/**
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ide: it821x in pass-through mode segfaults in 2.6.26-stable
2008-07-14 19:11 [PATCH] ide: it821x in pass-through mode segfaults in 2.6.26-stable Dimitri Gorokhovik
@ 2008-07-16 15:02 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-07-16 15:02 UTC (permalink / raw)
To: Dimitri Gorokhovik; +Cc: linux-ide, linux-kernel, stable
Hi,
On Monday 14 July 2008, Dimitri Gorokhovik wrote:
> (Let me know if you need the kernel config for this.)
> ---
> The driver of ITE8212 in pass-through mode (it8212.noraid=1 on cmndline)
> attempts to use the field `.dma_host_set' of the struct ide_dma_ops in
> `ide_config_drive_speed' which is set to NULL by default.
>
> So give a value to all fields of the struct ide_dma_ops.
Thank your for fixing it.
Please resend with your Signed-off-by: so I could apply it.
> ---
> diff --git a/drivers/ide/pci/it821x.c b/drivers/ide/pci/it821x.c
> index 6ab0411..cbf6472 100644
> --- a/drivers/ide/pci/it821x.c
> +++ b/drivers/ide/pci/it821x.c
> @@ -512,8 +512,14 @@ static void __devinit it821x_quirkproc(ide_drive_t *drive)
> }
>
> static struct ide_dma_ops it821x_pass_through_dma_ops = {
> + .dma_host_set = ide_dma_host_set,
> + .dma_setup = ide_dma_setup,
> + .dma_exec_cmd = ide_dma_exec_cmd,
> .dma_start = it821x_dma_start,
> .dma_end = it821x_dma_end,
> + .dma_test_irq = ide_dma_test_irq,
> + .dma_timeout = ide_dma_timeout,
> + .dma_lost_irq = ide_dma_lost_irq,
> };
>
> /**
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-15 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-14 19:11 [PATCH] ide: it821x in pass-through mode segfaults in 2.6.26-stable Dimitri Gorokhovik
2008-07-16 15:02 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).