Re: [PATCH 1/2] ide: ide-tape.c sparse annotations and unaligned access removal

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Wednesday 16 July 2008, Harvey Harrison wrote:
> On Wed, 2008-07-16 at 19:43 +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Tuesday 15 July 2008, Harvey Harrison wrote:
> > > If this is actually unaligned the access of speed/max_speed above
> > > is already broken and needs a get_unaligned.  Otherwise it is
> > > aligned and they can be removed.
> > > 
> > > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > > ---
> > > Bart, if this truly should be unaligned, let me know and I'll send you
> > > a patch fixing the speed/maxspeed issue.
> > 
> > I applied the patch as it is for now as I don't see a reason to
> > use unaligned access there but I could have forgotten some details
> > (added Borislav to cc:).
> > 
> > I've also noticed that there are some put_unaligned()-s left in
> > idetape_get_mode_sense_results(), is this intended?
> 
> I just fixed the immediate ones I saw right below the aligned access to 
> speed/max_speed.  I can't be sure about tape->caps being aligned or not,
> but at least the following incremental patch is ok if caps is 2-byte
> aligned.  Feel free to fold it into my original or put my signed-off by on
> a new commit.

Thanks, I folded it into original patch.