From: Ben Dooks <ben-linux@fluff.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Ben Dooks <ben-linux@fluff.org>,
linux-ide@vger.kernel.org, vince@simtec.co.uk
Subject: Re: [patch 1/1] LIBATA: Allow devices without IRQ specified to fall back
Date: Thu, 24 Jul 2008 12:26:37 +0100 [thread overview]
Message-ID: <20080724112637.GG26938@trinity.fluff.org> (raw)
In-Reply-To: <20080723201349.33226d58@lxorguk.ukuu.org.uk>
On Wed, Jul 23, 2008 at 08:13:49PM +0100, Alan Cox wrote:
> > Ok, however the drivers/ide/pci/alim15x3.c still works fine
> > on this board, so there's something that something in the libata
> > driver path not working properly. Possibly drivers/ata/pata_ali.c
> > that is missing something
>
> The old driver makes some rather iffy assumptions when dev->irq == 0 in
> part because the old IDE code predates PCI quirks.
>From reading the ALI M1543 datasheets that the interrupt pin in either
mode (compatibility or native) is routed directly into the inbuilt ISA-PIC,
and thus the IRQ field in the PCI child device is not available. This
means we need to be able to override the IRQ numbers for these devices.
I had a look, and there doesn't seem to be any way of specifying an
IRQ for a host port when registering with libata-sff.c, which is a
problem since we need to be able to either pass-in or have a callback
to allow our "quirk" to specify a new IRQ for the device.
Does anyone know if the ALi M5229 actually exists outside of one of
the M1543 bridges?
Note, this hardly seems to be a board-quirk, it is more of a device
quirk...
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
next prev parent reply other threads:[~2008-07-24 11:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080723144226.807475493@fluff.org>
2008-07-23 14:42 ` [patch 1/1] LIBATA: Allow devices without IRQ specified to fall back Ben Dooks
2008-07-23 15:32 ` Alan Cox
2008-07-23 19:04 ` Ben Dooks
2008-07-23 19:13 ` Alan Cox
2008-07-24 11:26 ` Ben Dooks [this message]
2008-07-24 11:13 ` Alan Cox
2008-07-24 11:50 ` Ben Dooks
2008-07-24 11:59 ` Alan Cox
2008-07-24 13:50 ` Ben Dooks
2008-07-24 13:52 ` Alan Cox
2008-07-24 14:17 ` Ben Dooks
2008-07-24 14:05 ` Alan Cox
2008-07-24 16:12 ` Bartlomiej Zolnierkiewicz
2008-07-24 16:06 ` Alan Cox
2008-07-24 17:05 ` Bartlomiej Zolnierkiewicz
2008-07-24 17:23 ` Alan Cox
2008-07-24 11:14 ` Alan Cox
2008-07-24 11:50 ` Ben Dooks
2008-07-24 11:58 ` Alan Cox
2008-07-24 13:52 ` Ben Dooks
2008-07-24 14:33 ` Alan Cox
2008-07-24 15:24 ` Ben Dooks
2008-07-24 15:26 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080724112637.GG26938@trinity.fluff.org \
--to=ben-linux@fluff.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=vince@simtec.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox