public inbox for linux-ide@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Dooks <ben-linux@fluff.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Ben Dooks <ben-linux@fluff.org>,
	linux-ide@vger.kernel.org, vince@simtec.co.uk
Subject: Re: [patch 1/1] LIBATA: Allow devices without IRQ specified to fall back
Date: Thu, 24 Jul 2008 14:50:02 +0100	[thread overview]
Message-ID: <20080724135002.GL26938@trinity.fluff.org> (raw)
In-Reply-To: <20080724125922.744923d7@lxorguk.ukuu.org.uk>

On Thu, Jul 24, 2008 at 12:59:22PM +0100, Alan Cox wrote:
> On Thu, 24 Jul 2008 12:50:42 +0100
> Ben Dooks <ben-linux@fluff.org> wrote:
> 
> > On Thu, Jul 24, 2008 at 12:13:28PM +0100, Alan Cox wrote:
> > > > I had a look, and there doesn't seem to be any way of specifying an
> > > > IRQ for a host port when registering with libata-sff.c, which is a
> > > > problem since we need to be able to either pass-in or have a callback
> > > > to allow our "quirk" to specify a new IRQ for the device.
> > > 
> > > Currently there is not. However if the device as a whole is wired to IRQ
> > > 14 you want to quirk pdev->irq.
> > 
> > That would be great if both channels are mapped to 14, however the
> > mapping set by default is for each channel to have an unique IRQ.
> 
> Ok so you've got a board reporting native mode using the legacy IRQ
> numbering (14/15 - or platform equivalents) ? In which case may I suggest
> you rewrite the header to indicate it is in legacy mode as per the BIOS
> guide ?

The drivers/ide/pci/alim15x3.c driver currently has code to correctly
set the IRQ fields for anything that isn't SPARC. Does this mean we
must disable the libata driver for anything that isn't SPARC? What about
other boards where this device combination is present?

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.


  reply	other threads:[~2008-07-24 13:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080723144226.807475493@fluff.org>
2008-07-23 14:42 ` [patch 1/1] LIBATA: Allow devices without IRQ specified to fall back Ben Dooks
2008-07-23 15:32   ` Alan Cox
2008-07-23 19:04     ` Ben Dooks
2008-07-23 19:13       ` Alan Cox
2008-07-24 11:26         ` Ben Dooks
2008-07-24 11:13           ` Alan Cox
2008-07-24 11:50             ` Ben Dooks
2008-07-24 11:59               ` Alan Cox
2008-07-24 13:50                 ` Ben Dooks [this message]
2008-07-24 13:52                   ` Alan Cox
2008-07-24 14:17                     ` Ben Dooks
2008-07-24 14:05                       ` Alan Cox
2008-07-24 16:12                       ` Bartlomiej Zolnierkiewicz
2008-07-24 16:06                         ` Alan Cox
2008-07-24 17:05                           ` Bartlomiej Zolnierkiewicz
2008-07-24 17:23                             ` Alan Cox
2008-07-24 11:14           ` Alan Cox
2008-07-24 11:50             ` Ben Dooks
2008-07-24 11:58               ` Alan Cox
2008-07-24 13:52                 ` Ben Dooks
2008-07-24 14:33                   ` Alan Cox
2008-07-24 15:24                     ` Ben Dooks
2008-07-24 15:26                       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080724135002.GL26938@trinity.fluff.org \
    --to=ben-linux@fluff.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-ide@vger.kernel.org \
    --cc=vince@simtec.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox