Re: [patch 1/1] LIBATA: Allow devices without IRQ specified to fall back

[Ben Dooks <ben-linux@fluff.org>]

On Thu, Jul 24, 2008 at 03:33:38PM +0100, Alan Cox wrote:
> > Ok, so this controller is not performing to the IRQ portion of the PCI
> > IDE specification, but is this any reason to force it back into legacy
> > mode?
> 
> Well the obvious reason to do that is that is what the BIOS guide says
> and what the standards expect. Given that legacy mode has no performance
> impact at all as it just changes the IRQ interpretation and the port
> mapping rules it seems silly not to do that

I've changed drivers/ata/pata_ali.c to change the mode back to compatibility
mode, but libata-sff.c is still trying to use the pci configuration BARs
to map the control registers. If the copy of the "PCI IDE Controller
Specification, Revision 1.0" [1] is to be belived, the values in the PCI BARs
should be ignored.

[1] http://suif.stanford.edu/~csapuntz/specs/pciide.ps
> Alan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ide" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.