From: Christoph Hellwig <hch@infradead.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] remove <linux/hdreg.h>
Date: Thu, 24 Jul 2008 16:22:09 -0400 [thread overview]
Message-ID: <20080724202209.GA30634@infradead.org> (raw)
In-Reply-To: <200807242211.53655.bzolnier@gmail.com>
On Thu, Jul 24, 2008 at 10:11:52PM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Thursday 24 July 2008, Christoph Hellwig wrote:
> > On Thu, Jul 24, 2008 at 09:37:58PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > > It has no in-kernel users now and can be removed.
> >
> > But beeing an exported header it has userspace users. Plese keep it
> > and just leave the ioctl defintions as need by userspace in it instead
> > of renaming that part to hdio_ioctls.h.
>
> Agreed w.r.t. to keeping it (the last patch was more of rfc than intended
> to be commited, sorry that I didn't mark it as such) but what's wrong with
> moving ioctl definitions to hdio_ioctls.h so we have clean separation of
> obsoleted userspace-only stuff & userspace/kernel stuff?
Well, if there was anything kernel-related left in hdreg.h I would
agree to split it, although I'd prefer to move the kernel part out.
But given that you kill all the kernel only bits anyway, just leave
the user interface in hdreg.h even if it's slightly misnamed.
next prev parent reply other threads:[~2008-07-24 20:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 19:37 [PATCH 4/4] remove <linux/hdreg.h> Bartlomiej Zolnierkiewicz
2008-07-24 19:49 ` Christoph Hellwig
2008-07-24 20:11 ` Bartlomiej Zolnierkiewicz
2008-07-24 20:22 ` Christoph Hellwig [this message]
2008-07-27 15:28 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080724202209.GA30634@infradead.org \
--to=hch@infradead.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).