From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [PATCH {1,3}/7] ata: add missing ATA_CMD_* defines
Date: Thu, 24 Jul 2008 21:07:36 +0200
Message-ID: <200807242107.36740.bzolnier@gmail.com>
References: <200807232042.45733.bzolnier@gmail.com> <200807232040.18264.bzolnier@gmail.com> <20080723235237.GA11354@puku.stupidest.org>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Return-path: <linux-ide-owner@vger.kernel.org>
Received: from mu-out-0910.google.com ([209.85.134.184]:52465 "EHLO
	mu-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753024AbYGXTOe (ORCPT
	<rfc822;linux-ide@vger.kernel.org>); Thu, 24 Jul 2008 15:14:34 -0400
Received: by mu-out-0910.google.com with SMTP id w8so2194484mue.1
        for <linux-ide@vger.kernel.org>; Thu, 24 Jul 2008 12:14:32 -0700 (PDT)
In-Reply-To: <20080723235237.GA11354@puku.stupidest.org>
Content-Disposition: inline
Sender: linux-ide-owner@vger.kernel.org
List-Id: linux-ide@vger.kernel.org
To: Chris Wedgwood <cw@f00f.org>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Garzik <jeff@garzik.org>

On Thursday 24 July 2008, Chris Wedgwood wrote:
> On Wed, Jul 23, 2008 at 08:40:18PM +0200, Bartlomiej Zolnierkiewicz wrote:
> 
> > Add missing ATA_CMD_* defines to <linux/ata.h>.  Also add
> > ATA_EXABYTE_ENABLE_NEST, SETFEATURES_AAM_* and ATA_SMART_*
> > defines while at it.
> >
> > Partially based on earlier work by Chris Wedgwood.
> 
> [...]
> 
> 
> On Wed, Jul 23, 2008 at 08:42:45PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > * Use ATA_CMD_* defines instead of WIN_* ones.
> >
> > While at it:
> >
> > * EXABYTE_ENABLE_NEXT -> ATA_EXABYTE_ENABLE_NEST
> >
> > * SETFEATURES_{EN,DIS}_WCACHE -> SETFEATURES_WC_{ON,OFF}
> >
> > * SETFEATURES_{EN,DIS}_AAM -> SETFEATURES_AAM_{ON,OFF}
> >
> > * SMART_* -> ATA_SMART_*
> >
> > * Remove stale comment from ide-proc.c.
> >
> > Partially based on earlier work by Chris Wedgwood.
> 
> ACK/signoff from me (in so far as it's relevant, my original patches
> are so old I'm sure Bart probably had to so it almost all again).

Thanks, added your ACK to #1/#3 and Jeff's to #1/#2.