From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: harvey.harrison@gmail.com, linux-ide@kernel.org,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: recent IDE regression
Date: Sat, 26 Jul 2008 14:04:49 +0200 [thread overview]
Message-ID: <200807261404.49947.bzolnier@gmail.com> (raw)
In-Reply-To: <20080724.233831.193691312.davem@davemloft.net>
On Friday 25 July 2008, David Miller wrote:
[...]
> Something like this:
>
> endian: Always evaluate arguments.
>
> Changeset 7fa897b91a3ea0f16c2873b869d7a0eef05acff4
> ("ide: trivial sparse annotations") created an IDE bootup
> regression on big-endian systems. In drivers/ide/ide-iops.c,
> function ide_fixstring() we now have the loop:
>
> for (p = end ; p != s;)
> be16_to_cpus((u16 *)(p -= 2));
>
> which will never terminate on big-endian because in such
> a configuration be16_to_cpus() evaluates to "do { } while (0)"
>
> Therefore, always evaluate the arguments to nop endian transformation
> operations.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
Thanks David.
PS We need more big-endian users testing linux-next (this particular patch
despite being trivial has been put there just-in-case for a week)
next prev parent reply other threads:[~2008-07-26 12:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 6:38 recent IDE regression David Miller
2008-07-25 8:34 ` Ben Dooks
2008-07-25 8:42 ` David Miller
2008-07-25 8:46 ` Ben Dooks
2008-07-25 16:37 ` Linus Torvalds
2008-07-25 22:17 ` Ben Dooks
2008-07-26 12:13 ` Bartlomiej Zolnierkiewicz
2008-07-26 12:04 ` Bartlomiej Zolnierkiewicz [this message]
2008-07-27 0:31 ` David Miller
2008-07-27 13:48 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807261404.49947.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=linux-ide@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).