From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] remove unneeded #include <linux/ide.h>'s
Date: Tue, 29 Jul 2008 21:43:22 +0200 [thread overview]
Message-ID: <200807292143.23094.bzolnier@gmail.com> (raw)
In-Reply-To: <20080729164831.GC23951@cs181140183.pp.htv.fi>
On Tuesday 29 July 2008, Adrian Bunk wrote:
> On Sun, Jul 27, 2008 at 04:32:16PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Sunday 27 July 2008, Adrian Bunk wrote:
> > > The sh systemh_defconfig currently fails to build with the following
> > > error:
> > >
> > > <-- snip -->
> > >
> > > ...
> > > CC arch/sh/boards/renesas/systemh/irq.o
> > > In file included from /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/sh/boards/renesas/systemh/irq.c:16:
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/ide.h:645: error: 'CONFIG_IDE_MAX_HWIFS' undeclared here (not in a function)
> > > make[2]: *** [arch/sh/boards/renesas/systemh/irq.o] Error 1
> >
> > Please also fix the source root of the problem:
> >
> > arch/sh/boards/renesas/systemh/irq.c should have no bussiness in
> > including include/linux/ide.h (which is for drivers/ide/ _only_)
> >...
>
> ide-scsi.c and the mediabay stuff might qualify as exceptions?
Yes, they are exceptions confirming the rule. :)
> For the rest a patch is below (on top of your #include <linux/hdreg.h>
> removal patch).
applied
prev parent reply other threads:[~2008-07-29 19:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-27 13:04 [2.6 patch] simplify MAX_HWIFS setting Adrian Bunk
2008-07-27 14:32 ` Bartlomiej Zolnierkiewicz
2008-07-29 16:48 ` [2.6 patch] remove CONFIG_IDE_MAX_HWIFS Adrian Bunk
2008-07-29 19:45 ` Bartlomiej Zolnierkiewicz
2008-07-29 16:48 ` [2.6 patch] remove unneeded #include <linux/ide.h>'s Adrian Bunk
2008-07-29 19:43 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807292143.23094.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=bunk@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).