From: Greg KH <gregkh@suse.de>
To: petkovbb@gmail.com, stable@kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Petr Tesarik <ptesarik@suse.cz>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
Jens Axboe <jens.axboe@oracle.com>, Jan Kara <jack@suse.cz>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [PATCH] ide-cd: fix endianity for the error message in cdrom_read_capacity
Date: Wed, 30 Jul 2008 09:33:28 -0700 [thread overview]
Message-ID: <20080730163327.GA23086@suse.de> (raw)
In-Reply-To: <9ea470500807300152p5d5414aaq2d0d0053c12ef3f5@mail.gmail.com>
On Wed, Jul 30, 2008 at 10:52:50AM +0200, Boris Petkov wrote:
> On Wed, Jul 30, 2008 at 10:18 AM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > On Wed, 30 Jul 2008 10:10:06 +0200 Petr Tesarik <ptesarik@suse.cz> wrote:
> >
> >> Resent because of a typo in the LKML address. :(
> >
> > Thanks.
> >
> >>
> >> Aesthetic regards aside, commit e8e7b9eb11c34ee18bde8b7011af41938d1ad667
> >> still leaves a bug in the error message, because it uses the unconverted
> >> big-endian value for printk.
> >>
> >> Fix this by using a local variable in machine byte order. The result is
> >> correct, more readable, and also produces slightly shorter code on i386.
> >>
> >> Cc: Jens Axboe <jens.axboe@oracle.com>
> >> Cc: Jan Kara <jack@suse.cz>
> >> Signed-off-by: Petr Tesarik <ptesarik@suse.cz>
>
> I definitely like this one better, thanks.
>
> Acked-by: Borislav Petkov <petkovbb@gmail.com>
>
>
> >
> > Bart owns this patch now. It got lost for a month and it has already
> > been fixed twice and it is also on the route to 2.6.25.x and 2.6.26.x,
> > so it'll get complicated. Not a happy little patch.
>
> Greg, can you please apply this one on top of -stable.
What one? Do you have a git commit id?
And please, send stable requests to stable@kernel.org, otherwise they
have a tendancy to get lost in my horrible inbox these days...
thanks,
greg k-h
next prev parent reply other threads:[~2008-07-30 16:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 8:10 [PATCH] ide-cd: fix endianity for the error message in cdrom_read_capacity Petr Tesarik
2008-07-30 8:18 ` Andrew Morton
2008-07-30 8:52 ` Boris Petkov
2008-07-30 16:33 ` Greg KH [this message]
2008-07-30 19:12 ` Borislav Petkov
2008-07-30 20:58 ` Greg KH
2008-07-31 3:32 ` Borislav Petkov
2008-07-30 19:27 ` Borislav Petkov
2008-07-30 19:25 ` Bartlomiej Zolnierkiewicz
2008-07-30 20:02 ` Andrew Morton
2008-07-30 21:23 ` Bartlomiej Zolnierkiewicz
-- strict thread matches above, loose matches on Subject: below --
2008-07-30 7:42 Petr Tesarik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730163327.GA23086@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=jack@suse.cz \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@gmail.com \
--cc=ptesarik@suse.cz \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).