From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH] ide-floppy: use scatterlists for pio transfers Date: Wed, 6 Aug 2008 21:30:56 +0200 Message-ID: <20080806193056.GA31312@gollum.tnic> References: <20080805051113.GA15834@gollum.tnic> <200808061805.01126.bzolnier@gmail.com> Reply-To: petkovbb@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from fg-out-1718.google.com ([72.14.220.153]:5459 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754557AbYHFTas (ORCPT ); Wed, 6 Aug 2008 15:30:48 -0400 Received: by fg-out-1718.google.com with SMTP id 19so40335fgg.17 for ; Wed, 06 Aug 2008 12:30:46 -0700 (PDT) Content-Disposition: inline In-Reply-To: <200808061805.01126.bzolnier@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, Aug 06, 2008 at 06:05:00PM +0200, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday 05 August 2008, Borislav Petkov wrote: > > Hi Bart, > > > > here's my first stab at using scatterlists in ide-floppy. I've adapted your > > ide-scsi version to fit in here. The change here is that i use pc->b_count as > > a sort-of completion counter to know when i'm at the end of the sg element and > > be able to switch to the next/finish transfer. I've tested the patch with the > > Iomega ZIP drive i have here - it works. We should do some more testing first > > though, before sending it upstream. > > [...] > > > @@ -569,7 +577,7 @@ static void idefloppy_create_rw_cmd(idefloppy_floppy_t *floppy, > > memcpy(rq->cmd, pc->c, 12); > > > > pc->rq = rq; > > - pc->b_count = cmd == READ ? 0 : rq->bio->bi_size; > > + pc->b_count = 0; > > if (rq->cmd_flags & REQ_RW) > > pc->flags |= PC_FLAG_WRITING; > > pc->buf = NULL; > > Don't we also need to zero pc->b_count in idefloppy_blockpc_cmd()? > > [ idefloppy_init_pc() clears whole pc so ->b_count assignment > to zero is not strictly necessary ] We probably should and i should've probably hit that during testing and maybe hit an OOPS along that path but we don't do REQ_TYPE_BLOCK_PC in ide-floppy yet, as it appears, and since idefloppy_blockpc_cmd() is only called when blk_pc_request(rq) that's why this one doesn't matter here. We should consider it though when we convert to using BLOCK_PC type rq's. -- Regards/Gruss, Boris.