From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH 1/2] pata_legacy: export functionality to ide Date: Wed, 6 Aug 2008 21:47:55 +0200 Message-ID: <20080806194754.GC31312@gollum.tnic> References: <20080803143837.GA26672@gollum.tnic> <20080803162214.394b13a1@lxorguk.ukuu.org.uk> <20080803165135.GA31977@gollum.tnic> <4898630C.7090403@ru.mvista.com> <9ea470500808050732s7be29360ge358790e955be06a@mail.gmail.com> <58cb370e0808050741v7ff3f20awb3d91a84486f8547@mail.gmail.com> <20080806061023.GA23773@gollum.tnic> <48998C58.20703@ru.mvista.com> <9ea470500808060703p4a94c868i25106e081aad75c4@mail.gmail.com> <4899C9F4.9040002@ru.mvista.com> Reply-To: petkovbb@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from fg-out-1718.google.com ([72.14.220.157]:8508 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756130AbYHFTrr (ORCPT ); Wed, 6 Aug 2008 15:47:47 -0400 Received: by fg-out-1718.google.com with SMTP id 19so46051fgg.17 for ; Wed, 06 Aug 2008 12:47:45 -0700 (PDT) Content-Disposition: inline In-Reply-To: <4899C9F4.9040002@ru.mvista.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Sergei Shtylyov Cc: Bartlomiej Zolnierkiewicz , Alan Cox , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org On Wed, Aug 06, 2008 at 07:57:40PM +0400, Sergei Shtylyov wrote: > Boris Petkov wrote: > >>>> From: Borislav Petkov >>>> Date: Sun, 3 Aug 2008 18:46:35 +0200 >>>> Subject: [PATCH] ide-generic: handle probing of legacy io-ports v4 > >>>> Avoid probing the io-ports in case an IDE PCI controller is present and it uses >>>> the legacy iobases. If we still want to enforce the probing, we do > >>>> ide_generic.probe_mask=0x3f > >>>> on the kernel command line. The iobase checking code is adapted from >>>> drivers/ata/pata_legacy.c after converting hex pci ids into their >>>> corresponding >>>> macros in . > >>>> CC: Sergei Shtylyov >>>> Signed-off-by: Borislav Petkov > >>> Acked-by: Sergei Shtylyov > >>>> diff --git a/drivers/ide/ide-generic.c b/drivers/ide/ide-generic.c >>>> index 8fe8b5b..efce159 100644 >>>> --- a/drivers/ide/ide-generic.c >>>> +++ b/drivers/ide/ide-generic.c > >>> [...] > >>>> @@ -100,19 +101,69 @@ static const u16 legacy_bases[] = { 0x1f0, 0x170, >>>> 0x1e8, 0x168, 0x1e0, 0x160 }; >>>> static const int legacy_irqs[] = { 14, 15, 11, 10, 8, 12 }; >>>> #endif >>>> +static void ide_generic_check_pci_legacy_iobases(int *primary, int >>>> *secondary) >>>> +{ >>>> + struct pci_dev *p = NULL; >>>> + u16 val; >>>> + >>>> + for_each_pci_dev(p) { >>>> + int r; >>>> + >>>> + for (r = 0; r < 6; r++) { >>>> + if (pci_resource_start(p, r) == 0x1f0) >>>> + *primary = 1; >>>> + if (pci_resource_start(p, r) == 0x170) >>>> + *secondary = 1; >>>> + } > >>> Would have been probably enough to test only BAR0/2, don't you think? > >> I assume you're referring to the legacy ioports fixup in >> drivers/pci/probe.c:pci_setup_device(). > > And to the fact that the value 0x1f0 should only be ever seen in BAR0 > and 0x170 in BAR2 even if they would have been read off the chips (some > chips have these values reading back even in legacy mode, and even could > malfunction if other values are written there), not fixed up there, and > certainly not in BAR1 or BAR3, so it's quite pointless to look in these > BARs too. So the comment in there saying that in some cases BAR0-3 could contain junk is a bogus? In other words, can we assume that one will always read 0x1f0 from BAR0 and 0x170 from BAR2 in compatibility mode. If so, the check is even simpler: if (pci_resource_start(p, 0) == 0x1f0) *primary = 1; if (pci_resource_start(p, 2) == 0x170) *secondary = 1; -- Regards/Gruss, Boris.