From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org
Subject: Re: [2.6 patch] drivers/ide/pci/: use __devexit_p()
Date: Fri, 8 Aug 2008 18:14:58 +0200 [thread overview]
Message-ID: <200808081814.58997.bzolnier@gmail.com> (raw)
In-Reply-To: <20080807170932.GC9692@cs181140183.pp.htv.fi>
On Thursday 07 August 2008, Adrian Bunk wrote:
> On Thu, Aug 07, 2008 at 05:45:39PM +0100, Russell King wrote:
> >...
> > --- a/drivers/ide/pci/hpt366.c
> > +++ b/drivers/ide/pci/hpt366.c
> > @@ -1594,7 +1594,7 @@ static int __devinit hpt366_init_one(struct pci_dev *dev, const struct pci_devic
> > return ret;
> > }
> >
> > -static void __devexit hpt366_remove(struct pci_dev *dev)
> > +static void hpt366_remove(struct pci_dev *dev)
> >...
>
> Thanks for your report.
>
> The code is buggy, but:
> - that's not the correct fix and
> - there are far more such bugs under drivers/ide/pci/
>
> Patch below.
>
> > Russell King
>
> cu
> Adrian
>
>
> <-- snip -->
>
>
> This patch adds missing __devexit_p's.
>
> Reported-by: Russell King <rmk+lkml@arm.linux.org.uk>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
applied, thanks
prev parent reply other threads:[~2008-08-08 16:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 16:45 [WHINGE+PATCH] Stupid structure naming and stupid linker error messages Russell King
2008-08-07 17:09 ` [2.6 patch] drivers/ide/pci/: use __devexit_p() Adrian Bunk
2008-08-08 16:14 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808081814.58997.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=bunk@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).