From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: linux-ide@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 8/9] ide: remove superfluous ->dma field from ide_hwif_t
Date: Sun, 17 Aug 2008 19:15:48 +0200 [thread overview]
Message-ID: <20080817171548.27943.58522.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20080817171454.27943.37234.sendpatchset@localhost.localdomain>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ide-dma.c | 2 --
drivers/ide/pci/scc_pata.c | 2 --
include/linux/ide.h | 2 --
3 files changed, 6 deletions(-)
Index: b/drivers/ide/ide-dma.c
===================================================================
--- a/drivers/ide/ide-dma.c
+++ b/drivers/ide/ide-dma.c
@@ -525,7 +525,6 @@ void ide_dma_start(ide_drive_t *drive)
outb(dma_cmd | 1, hwif->dma_base + ATA_DMA_CMD);
}
- hwif->dma = 1;
wmb();
}
@@ -564,7 +563,6 @@ int __ide_dma_end (ide_drive_t *drive)
/* purge DMA mappings */
ide_destroy_dmatable(drive);
/* verify good DMA status */
- hwif->dma = 0;
wmb();
return (dma_stat & 7) != 4 ? (0x10 | dma_stat) : 0;
}
Index: b/drivers/ide/pci/scc_pata.c
===================================================================
--- a/drivers/ide/pci/scc_pata.c
+++ b/drivers/ide/pci/scc_pata.c
@@ -353,7 +353,6 @@ static void scc_dma_start(ide_drive_t *d
/* start DMA */
scc_ide_outb(dma_cmd | 1, hwif->dma_base);
- hwif->dma = 1;
wmb();
}
@@ -374,7 +373,6 @@ static int __scc_dma_end(ide_drive_t *dr
/* purge DMA mappings */
ide_destroy_dmatable(drive);
/* verify good DMA status */
- hwif->dma = 0;
wmb();
return (dma_stat & 7) != 4 ? (0x10 | dma_stat) : 0;
}
Index: b/include/linux/ide.h
===================================================================
--- a/include/linux/ide.h
+++ b/include/linux/ide.h
@@ -745,8 +745,6 @@ typedef struct hwif_s {
void *hwif_data; /* extra hwif data */
- unsigned dma;
-
#ifdef CONFIG_BLK_DEV_IDEACPI
struct ide_acpi_hwif_link *acpidata;
#endif
next prev parent reply other threads:[~2008-08-17 17:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-17 17:14 [PATCH 1/9] ide: fix IDE ACPI for slave device-only configurations Bartlomiej Zolnierkiewicz
2008-08-17 17:15 ` [PATCH 2/9] ide-disk: set_addressing() fixes Bartlomiej Zolnierkiewicz
2008-08-23 21:45 ` Sergei Shtylyov
2008-08-25 20:23 ` Bartlomiej Zolnierkiewicz
2008-08-17 17:15 ` [PATCH 3/9] ide-disk: remove stale init_idedisk_capacity() documentation Bartlomiej Zolnierkiewicz
2008-08-20 10:06 ` Sergei Shtylyov
2008-08-17 17:15 ` [PATCH 4/9] ide-disk: add ide_do_setfeature() helper Bartlomiej Zolnierkiewicz
2008-08-20 10:04 ` Sergei Shtylyov
2008-08-17 17:15 ` [PATCH 5/9] ide: add device flags Bartlomiej Zolnierkiewicz
2008-08-17 17:15 ` [PATCH 6/9] ide: DMA_PIO_RETRY -> IDE_DFLAG_DMA_PIO_RETRY Bartlomiej Zolnierkiewicz
2008-08-17 17:15 ` [PATCH 7/9] ide: remove superfluous ->media field from ide_driver_t Bartlomiej Zolnierkiewicz
2008-08-23 21:07 ` Sergei Shtylyov
2008-08-17 17:15 ` Bartlomiej Zolnierkiewicz [this message]
2008-08-20 10:15 ` [PATCH 8/9] ide: remove superfluous ->dma field from ide_hwif_t Sergei Shtylyov
2008-08-17 17:15 ` [PATCH 9/9] ide: remove superfluous ->waiting_for_dma checks Bartlomiej Zolnierkiewicz
2008-08-20 10:08 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080817171548.27943.58522.sendpatchset@localhost.localdomain \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).