From: Martin Michlmayr <tbm@cyrius.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-ide@vger.kernel.org, linux-pcmcia@lists.infradead.org,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Dominik Brodowski <linux@dominikbrodowski.net>
Subject: Re: 2.6.27-rc3: IP: [<ffffffffa0038b77>] init_irq+0x18d/0x31c [ide_core]
Date: Mon, 25 Aug 2008 14:02:41 +0300 [thread overview]
Message-ID: <20080825110241.GI2606@deprecation.cyrius.com> (raw)
In-Reply-To: <48ADAC7C.7040003@lwfinger.net>
* Larry Finger <Larry.Finger@lwfinger.net> [2008-08-21 12:57]:
> Do you have a git tree, or have you downloaded snapshots? If the
> former, a bisection would be useful.
I've bisected it down to this change: ide: set hwif->dev in ide_init_port_hw() (take 2)
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c56c5648a3bd15ff14c50f284b261140cd5b5472
I cannot revert this from current git because there were too many
changes but when I go to 5b664cb235e97afbf34db9c4d77f08ebd725335e (a
random point that shows the oops) and apply the following (which is
basically a partial revert of the c56c5648a3bd15ff14c50f284b261140cd5b5472)
then it works:
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -284,7 +284,6 @@ void ide_init_port_hw(ide_hwif_t *hwif, hw_regs_t *hw)
memcpy(&hwif->io_ports, &hw->io_ports, sizeof(hwif->io_ports));
hwif->irq = hw->irq;
hwif->chipset = hw->chipset;
- hwif->dev = hw->dev;
hwif->gendev.parent = hw->parent ? hw->parent : hw->dev;
hwif->ack_intr = hw->ack_intr;
}
diff --git a/drivers/ide/setup-pci.c b/drivers/ide/setup-pci.c
index 65fc08b..187b7b1 100644
--- a/drivers/ide/setup-pci.c
+++ b/drivers/ide/setup-pci.c
@@ -339,6 +339,8 @@ static ide_hwif_t *ide_hwif_configure(struct pci_dev *dev,
ide_init_port_hw(hwif, &hw);
+ hwif->dev = &dev->dev;
+
return hwif;
}
--
Martin Michlmayr
http://www.cyrius.com/
next prev parent reply other threads:[~2008-08-25 11:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 17:31 2.6.27-rc3: IP: [<ffffffffa0038b77>] init_irq+0x18d/0x31c [ide_core] Martin Michlmayr
2008-08-20 19:34 ` Larry Finger
[not found] ` <20080821161610.GA2640@deprecation.cyrius.com>
2008-08-21 17:34 ` Larry Finger
2008-08-21 17:52 ` Martin Michlmayr
2008-08-21 17:57 ` Larry Finger
2008-08-25 11:02 ` Martin Michlmayr [this message]
2008-08-25 19:11 ` Bartlomiej Zolnierkiewicz
2008-08-26 5:17 ` Martin Michlmayr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080825110241.GI2606@deprecation.cyrius.com \
--to=tbm@cyrius.com \
--cc=Larry.Finger@lwfinger.net \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linux@dominikbrodowski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).