From: Frans Pop <elendil@planet.nl>
To: linux-arm@vger.kernel.org
Cc: linux-ide@vger.kernel.org, Saeed Bishara <saeed@marvell.com>,
Mark Lord <liml@rtr.ca>, Nicolas Pitre <nico@cam.org>,
Lennert Buytenhek <buytenh@wantstofly.org>
Subject: Re: [regression] sata_mv: harddisk activity led no longer responsive on QNAP TS-109
Date: Tue, 26 Aug 2008 12:25:45 +0200 [thread overview]
Message-ID: <200808261225.46315.elendil@planet.nl> (raw)
In-Reply-To: <200808261124.39282.elendil@planet.nl>
On Tuesday 26 August 2008, Frans Pop wrote:
> After booting the system I did 'echo 1 >/sys/block/sdX/device/queue_depth'
> and after that the HDD led showed disk activity again.
And to confirm that, applying the following patch to sata_mv for 2.6.26.3
makes the HDD led work again as well:
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -131,7 +131,7 @@ enum {
MV_GENIIE_FLAGS = MV_COMMON_FLAGS | MV_6XXX_FLAGS |
ATA_FLAG_PMP | ATA_FLAG_ACPI_SATA |
- ATA_FLAG_NCQ | ATA_FLAG_AN,
+ ATA_FLAG_AN,
CRQB_FLAG_READ = (1 << 0),
CRQB_TAG_SHIFT = 1,
So somehow enabling NCQ is at the root of the issue.
Cheers,
FJP
next prev parent reply other threads:[~2008-08-26 10:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 9:24 [regression] sata_mv: harddisk activity led no longer responsive on QNAP TS-109 Frans Pop
2008-08-26 10:25 ` Frans Pop [this message]
2009-01-24 14:57 ` Mark Lord
2009-02-24 8:33 ` [RFC][PATCH] " Frans Pop
2009-02-24 9:33 ` saeed bishara
2009-03-01 7:59 ` Martin Michlmayr
2009-03-01 12:44 ` Frans Pop
2009-03-10 11:36 ` [RFC][PATCH] sata-mv: add module parameter msq_blink_led to enable quirk for SOC Frans Pop
2009-03-10 15:06 ` Mark Lord
2009-03-10 16:28 ` Martin Michlmayr
2009-03-10 16:40 ` Mark Lord
2009-03-10 16:47 ` Frans Pop
2009-03-10 17:09 ` Frans Pop
2008-08-26 14:03 ` [regression] sata_mv: harddisk activity led no longer responsive on QNAP TS-109 Mark Lord
2008-08-27 14:56 ` Martin Michlmayr
2008-08-27 17:06 ` saeed bishara
-- strict thread matches above, loose matches on Subject: below --
2008-08-26 8:45 Frans Pop
2008-08-27 17:29 ` saeed bishara
2008-08-28 9:25 ` Frans Pop
2008-08-28 10:53 ` saeed bishara
2008-08-28 11:17 ` Frans Pop
2008-08-28 15:53 ` Grant Grundler
2008-08-28 17:11 ` Frans Pop
2008-08-28 17:26 ` Grant Grundler
2008-08-28 18:03 ` Frans Pop
2008-08-29 1:47 ` Harald Welte
2008-08-28 18:11 ` Lennert Buytenhek
2008-08-28 18:43 ` Frans Pop
2008-08-28 22:08 ` saeed bishara
2008-08-28 22:40 ` Frans Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808261225.46315.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=buytenh@wantstofly.org \
--cc=liml@rtr.ca \
--cc=linux-arm@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=nico@cam.org \
--cc=saeed@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).