From: David Milburn <dmilburn@redhat.com>
To: jeff@garzik.org
Cc: linux-ide@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: [PATCH] pata_sil680: remove duplicate pcim_enable_device
Date: Fri, 29 Aug 2008 10:36:28 -0500 [thread overview]
Message-ID: <20080829153628.GA20130@dhcp-210.hsv.redhat.com> (raw)
Remove duplicate call to pcim_enable_device in sil680_init_one.
Signed-off-by: David Milburn <dmilburn@redhat.com>
---
drivers/ata/pata_sil680.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/pata_sil680.c b/drivers/ata/pata_sil680.c
index 720b864..e970b22 100644
--- a/drivers/ata/pata_sil680.c
+++ b/drivers/ata/pata_sil680.c
@@ -322,9 +322,6 @@ static int __devinit sil680_init_one(struct pci_dev *pdev,
/* Try to acquire MMIO resources and fallback to PIO if
* that fails
*/
- rc = pcim_enable_device(pdev);
- if (rc)
- return rc;
rc = pcim_iomap_regions(pdev, 1 << SIL680_MMIO_BAR, DRV_NAME);
if (rc)
goto use_ioports;
next reply other threads:[~2008-08-29 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 15:36 David Milburn [this message]
2008-08-29 15:50 ` [PATCH] pata_sil680: remove duplicate pcim_enable_device Alan Cox
2008-08-30 11:09 ` Tejun Heo
2008-09-08 16:16 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080829153628.GA20130@dhcp-210.hsv.redhat.com \
--to=dmilburn@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).