From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Masoud Sharbiani <masouds@google.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] Fix pointer arithmetic in hpt3xx driver code (3rd try)
Date: Sun, 7 Sep 2008 20:10:03 +0200 [thread overview]
Message-ID: <200809072010.04122.bzolnier@gmail.com> (raw)
In-Reply-To: <48C3B909.3030405@ru.mvista.com>
Hi,
Masoud/Sergei: sorry for the bug and thanks for fixing it.
On Sunday 07 September 2008, Sergei Shtylyov wrote:
> Hello, I wrote:
> >> diff --git a/drivers/ide/pci/hpt366.c b/drivers/ide/pci/hpt366.c
> >> index eb107ee..4eae284 100644
> >> --- a/drivers/ide/pci/hpt366.c
> >> +++ b/drivers/ide/pci/hpt366.c
> >> @@ -613,6 +613,14 @@ static int check_in_drive_list(ide_drive_t
> >> *drive, const char **list)
> >> return 0;
> >> }
> >>
> >> +static struct hpt_info *hpt3xx_get_info(struct device *dev)
> >> +{
> >> + struct ide_host *host = pci_get_drvdata(to_pci_dev(pci_dev));
> >>
> >
> > Oops, this just won't compile. :-/
>
> BTW, there's no need to invoke to_pci_dev() at all since
> pci_get_drvdata(dev) boils down to dev_get_drvdata(&dev->dev) call. So,
> in order not to waste time on useless pointer tricks, we should just
> invoke the latter here.
I corrected this and applied the patch.
next prev parent reply other threads:[~2008-09-07 18:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080906171850.GF26371@google.com>
2008-09-07 9:21 ` [PATCH] Fix pointer arithmetic in hpt3xx driver code (3rd try) Sergei Shtylyov
2008-09-07 11:20 ` Sergei Shtylyov
2008-09-07 18:10 ` Bartlomiej Zolnierkiewicz [this message]
2008-09-08 17:21 ` Masoud Sharbiani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809072010.04122.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masouds@google.com \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).