From: Frans Pop <elendil@planet.nl>
To: Saeed Bishara <saeed@marvell.com>
Cc: linux-ide@vger.kernel.org, linux-arm@vger.kernel.org,
jeff@garzik.org, liml@rtr.ca, grundler@google.com,
buytenh@marvell.com, nico@marvell.com, tbm@cyrius.com
Subject: Re: [PATCH] sata_mv: enable active LED blink mode for SoC
Date: Mon, 8 Sep 2008 02:32:22 +0200 [thread overview]
Message-ID: <200809080232.23834.elendil@planet.nl> (raw)
In-Reply-To: <12207863853449-git-send-email-saeed@marvell.com>
Hello Saeed,
On Sunday 07 September 2008, Saeed Bishara wrote:
> Enabling blink mode makes the SATA active LED more human visible.
The patch does make the led responsive, but it does *not* restore it to
the old behavior.
With the 2.6.25 kernel (and also during early boot of the device) the
HDD led flashes with an intensity that reflects the amount of disk
activity (possibly the amount of data transferred), very similar to the
LAN led.
The flashing was subtle, but very well visible both with low and with high
disk activity.
With 2.6.26.3 without this patch there is no flashing visible at all.
With this patch applied to 2.6.26.3 I only get a very slow and steady
blinking of the HDD led. A very regular, almost lazy on/off.
The flashing is related to disk activity in that the led stays on when
there is no activity, but any relationship to the *intensity* of the disk
activity is lost.
So, IMO it is an improvement, but it is definitely not a fix for the
regression.
Cheers,
FJP
next prev parent reply other threads:[~2008-09-08 0:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-07 11:19 [PATCH] sata_mv: enable active LED blink mode for SoC Saeed Bishara
2008-09-07 11:31 ` saeed bishara
2008-09-08 0:32 ` Frans Pop [this message]
2008-09-08 13:40 ` Mark Lord
2008-09-08 14:16 ` Frans Pop
2008-09-08 14:25 ` Frans Pop
2008-09-08 15:18 ` Simon Farnsworth
2008-09-08 15:37 ` Saeed Bishara
2008-09-08 18:44 ` Mark Lord
2008-09-08 18:47 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809080232.23834.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=buytenh@marvell.com \
--cc=grundler@google.com \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-arm@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=nico@marvell.com \
--cc=saeed@marvell.com \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).