Re: PCI: Add ALI M5229 comaptibility mode quirk

[Matthew Wilcox <matthew@wil.cx>]

On Fri, Sep 12, 2008 at 02:00:43PM +0100, Ben Dooks wrote:
> On Fri, Sep 12, 2008 at 06:33:40AM -0600, Matthew Wilcox wrote:
> > On Fri, Sep 12, 2008 at 12:22:52PM +0100, Ben Dooks wrote:
> > > The M5229 implementation embedded into the ALI M1543 uses the
> > > M1543's ISA PIC to provide the interrupts and thus does not have
> > > an valid PCI IRQ set. This quirk detects the abscence of IRQ and
> > > sets the M5229 back into compatibility mode to use IRQs 14 and 15
> > > so that libata works correctly.
> > 
> > Why does this need to be a quirk rather than something in the libata ALi
> > driver?
> 
> The short answer is that "Alan Cox says not in libata", the longer
> one can be found:
> 
> http://www.archivum.info/linux-ide@vger.kernel.org/2008-07/msg00410.html

Thanks for the reference.  I've now read that thread.  I'm not entirely
convinced Alan is right; I think it's preferable to confine this
quirking to the driver and fix up the BARs in the driver as well.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."