From: Mark de Wever <koraq@xs4all.nl>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Gadi Oxman <gadio@netvision.net.il>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IDE-TAPE NULL terminate strings.
Date: Sun, 21 Sep 2008 22:29:15 +0200 [thread overview]
Message-ID: <20080921202915.GA17945@localhost> (raw)
In-Reply-To: <48D6A9BB.1070705@ru.mvista.com>
On Mon, Sep 22, 2008 at 12:08:27AM +0400, Sergei Shtylyov wrote:
>>> diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
>>> index 1bce84b..fd87b43 100644
>>> --- a/drivers/ide/ide-tape.c
>>> +++ b/drivers/ide/ide-tape.c
>>> @@ -2354,6 +2354,10 @@ static void
>>> idetape_get_inquiry_results(ide_drive_t *drive)
>>> ide_fixstring(product_id, 18, 0);
>>> ide_fixstring(fw_rev, 6, 0);
>
> Hm, I see that every string variable declared there has 2 extra
> characters, and yet the author have managed to make a mistake... these
> extra chars don't seem needed.
Those extra characters made me believe the intention was setting the
NULL character, therefore I used that solution in my patch.
Regards,
Mark de Wever
next prev parent reply other threads:[~2008-09-21 20:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-21 18:51 [PATCH] IDE-TAPE NULL terminate strings Mark de Wever
2008-09-21 19:24 ` Sergei Shtylyov
2008-09-21 20:08 ` Sergei Shtylyov
2008-09-21 20:29 ` Mark de Wever [this message]
2008-09-21 22:12 ` Sergei Shtylyov
2008-09-22 13:16 ` Sergei Shtylyov
2008-09-22 13:56 ` Boris Petkov
2008-09-22 20:41 ` Mark de Wever
2008-09-22 21:08 ` Sergei Shtylyov
2008-09-23 7:48 ` Borislav Petkov
2008-09-23 9:29 ` Sergei Shtylyov
2008-09-23 13:40 ` Boris Petkov
2008-09-23 16:59 ` Mark de Wever
2008-09-23 17:11 ` Boris Petkov
2008-09-23 21:20 ` IDE-TAPE regressions [was: [PATCH] IDE-TAPE NULL terminate strings.] Mark de Wever
2008-10-07 18:26 ` [patch][repost] ide-tape build fix Mark de Wever
2008-10-08 6:33 ` Borislav Petkov
2008-10-08 15:45 ` Mark de Wever
2008-10-08 16:22 ` Boris Petkov
2008-10-08 18:37 ` Bartlomiej Zolnierkiewicz
2008-09-24 7:10 ` [PATCH] IDE-TAPE NULL terminate strings Borislav Petkov
2008-09-24 9:36 ` Sergei Shtylyov
2008-09-27 17:04 ` Bartlomiej Zolnierkiewicz
2008-09-23 16:14 ` Mark de Wever
2008-09-23 17:10 ` Sergei Shtylyov
2008-09-23 17:27 ` Mark de Wever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080921202915.GA17945@localhost \
--to=koraq@xs4all.nl \
--cc=bzolnier@gmail.com \
--cc=gadio@netvision.net.il \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).