From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark de Wever Subject: Re: [PATCH] IDE-TAPE NULL terminate strings. Date: Tue, 23 Sep 2008 18:59:14 +0200 Message-ID: <20080923165914.GA7803@localhost> References: <20080921185138.GA16310@localhost> <48D79ABD.8060805@ru.mvista.com> <9ea470500809220656j6dfcf4c9q7a5a4185481ec994@mail.gmail.com> <20080922204129.GA3495@localhost> <48D80949.4080901@ru.mvista.com> <20080923074845.GB5656@gollum.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp-vbr12.xs4all.nl ([194.109.24.32]:2518 "EHLO smtp-vbr12.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752695AbYIWRDs (ORCPT ); Tue, 23 Sep 2008 13:03:48 -0400 Content-Disposition: inline In-Reply-To: <20080923074845.GB5656@gollum.tnic> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: petkovbb@gmail.com, Sergei Shtylyov , Gadi Oxman , Bartlomiej Zolnierkiewicz , linux-ide@vger.kernel.org, linux-ke On Tue, Sep 23, 2008 at 09:48:45AM +0200, Borislav Petkov wrote: > --- > diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c > index 1bce84b..3833189 100644 > --- a/drivers/ide/ide-tape.c > +++ b/drivers/ide/ide-tape.c > @@ -2338,7 +2338,7 @@ static void idetape_get_inquiry_results(ide_drive_t *drive) > { > idetape_tape_t *tape = drive->driver_data; > struct ide_atapi_pc pc; > - char fw_rev[6], vendor_id[10], product_id[18]; > + char fw_rev[4], vendor_id[8], product_id[16]; > > idetape_create_inquiry_cmd(&pc); > if (idetape_queue_pc_tail(drive, &pc)) { > @@ -2350,11 +2350,11 @@ static void idetape_get_inquiry_results(ide_drive_t *drive) > memcpy(product_id, &pc.buf[16], 16); > memcpy(fw_rev, &pc.buf[32], 4); > > - ide_fixstring(vendor_id, 10, 0); > - ide_fixstring(product_id, 18, 0); > - ide_fixstring(fw_rev, 6, 0); > + ide_fixstring(vendor_id, 8, 0); > + ide_fixstring(product_id, 16, 0); > + ide_fixstring(fw_rev, 4, 0); > > - printk(KERN_INFO "ide-tape: %s <-> %s: %s %s rev %s\n", > + printk(KERN_INFO "ide-tape: %s <-> %s: %.8s %.16s rev %.4s\n", > drive->name, tape->name, vendor_id, product_id, fw_rev); > } > > I think this patch looks good, better as all previous versions (including my initial version). I just tested it and it solves the problem. Feel free to add my tested-by. Regards, Mark de Wever PS I was not able to test earlier ;-)