From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark de Wever Subject: IDE-TAPE regressions [was: [PATCH] IDE-TAPE NULL terminate strings.] Date: Tue, 23 Sep 2008 23:20:18 +0200 Message-ID: <20080923212018.GA3348@localhost> References: <20080921185138.GA16310@localhost> <48D79ABD.8060805@ru.mvista.com> <9ea470500809220656j6dfcf4c9q7a5a4185481ec994@mail.gmail.com> <20080922204129.GA3495@localhost> <48D80949.4080901@ru.mvista.com> <20080923074845.GB5656@gollum.tnic> <20080923165914.GA7803@localhost> <9ea470500809231011p5ea37fc4u71eeeddf6ccec45a@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp-vbr16.xs4all.nl ([194.109.24.36]:1500 "EHLO smtp-vbr16.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755225AbYIWVUp (ORCPT ); Tue, 23 Sep 2008 17:20:45 -0400 Content-Disposition: inline In-Reply-To: <9ea470500809231011p5ea37fc4u71eeeddf6ccec45a@mail.gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: petkovbb@gmail.com Cc: Sergei Shtylyov , Gadi Oxman , Bartlomiej Zolnierkiewicz , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Sep 23, 2008 at 07:11:04PM +0200, Boris Petkov wrote: > No worries and thanks. By the way, you mentioned something about other problems > with ide-tape. FWIW, it seems you're its only user and we were about to kill it > but decided not to yet and did the whole cleanup kinda only by compile-testing > since almost no one (well, except you :)) has the hardware. So, feel free to > send me any dmesg/debug/error messages you get and I'll look into them. Also, > set IDETAPE_DEBUG_LOG to 1 before compiling for full debug info. Thanks for not killing the driver :-) Feel free to add me to your list of testers in case you need more testing in the future. I already posted the problem [1] but didn't CC you since your name wasn't listed in MAINTAINERS. I recompiled the kernel and tested again, but the output doesn't seem to contain extra output. In order to compile the kernel with IDETAPE_DEBUG_LOG enabled I had to apply the following build fix. Signed-off-by: Mark de Wever diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 3833189..7258eca 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -978,9 +978,10 @@ static ide_startstop_t idetape_do_request(ide_drive_t *drive, struct request *postponed_rq = tape->postponed_rq; u8 stat; - debug_log(DBG_SENSE, "sector: %ld, nr_sectors: %ld," + debug_log(DBG_SENSE, "sector: %llu, nr_sectors: %ld," " current_nr_sectors: %d\n", - rq->sector, rq->nr_sectors, rq->current_nr_sectors); + (unsigned long long)rq->sector, rq->nr_sectors, + rq->current_nr_sectors); if (!blk_special_request(rq)) { /* We do not support buffer cache originated requests. */ [1] http://marc.info/?l=linux-kernel&m=122203193728465&w=2 Regards, Mark de Wever