From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
linux-mips@linux-mips.org, linux-ide@vger.kernel.org,
ralf@linux-mips.org
Subject: Re: [PATCH 1/2] ide: Add tx4939ide driver (v2)
Date: Sat, 27 Sep 2008 18:19:56 +0200 [thread overview]
Message-ID: <200809271819.57244.bzolnier@gmail.com> (raw)
In-Reply-To: <48D57245.8060606@ru.mvista.com>
On Saturday 20 September 2008, Sergei Shtylyov wrote:
[...]
> But actually setting the controller's timings prior to issuing SET
> FEATURES doesn't seem safe anyway. Bart, don't you think that we should
> always call set_{dma|pio}_mode() AFTER ide_config_drive_speed() --
> we have no guarantee that the drive will accept the mode...
I remember some discussion about this issue in the past but currently I
don't see a reason why we shouldn't do it this way. Care to make a patch?
Thanks,
Bart
prev parent reply other threads:[~2008-09-27 17:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-17 15:13 [PATCH 1/2] ide: Add tx4939ide driver (v2) Atsushi Nemoto
2008-09-17 21:58 ` Jeff Garzik
2008-09-18 16:10 ` Atsushi Nemoto
2008-09-18 23:45 ` Bartlomiej Zolnierkiewicz
2008-09-19 9:25 ` Sergei Shtylyov
2008-09-19 17:10 ` Bartlomiej Zolnierkiewicz
2008-09-20 18:26 ` Sergei Shtylyov
2008-09-20 21:59 ` Sergei Shtylyov
2008-09-21 9:21 ` Sergei Shtylyov
2008-09-21 16:32 ` Atsushi Nemoto
2008-09-24 11:32 ` Sergei Shtylyov
2008-09-24 18:26 ` Sergei Shtylyov
2008-09-25 13:41 ` Atsushi Nemoto
2008-09-25 13:16 ` Atsushi Nemoto
2008-09-23 17:04 ` Atsushi Nemoto
2008-09-23 17:20 ` Sergei Shtylyov
2008-09-27 16:19 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809271819.57244.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-ide@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).