* [PATCH] Swarm: Fix crash due to missing initialization
@ 2008-09-21 20:47 Ralf Baechle
2008-09-27 16:30 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Ralf Baechle @ 2008-09-21 20:47 UTC (permalink / raw)
To: bzolnier, linux-ide; +Cc: linux-mips
If things are just right this will result in the hws[0]->parent being
passed to ide_host_add() being non-zero and an ooops a little later.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
---
This patch is needed for 2.6.27 only
diff --git a/drivers/ide/mips/swarm.c b/drivers/ide/mips/swarm.c
index badf79f..39c9ee9 100644
--- a/drivers/ide/mips/swarm.c
+++ b/drivers/ide/mips/swarm.c
@@ -107,6 +107,7 @@ static int __devinit swarm_ide_probe(struct device *dev)
base = ioremap(offset, size);
+ memset(&hw, 0, sizeof(hw));
for (i = 0; i <= 7; i++)
hw.io_ports_array[i] =
(unsigned long)(base + ((0x1f0 + i) << 5));
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Swarm: Fix crash due to missing initialization
2008-09-21 20:47 [PATCH] Swarm: Fix crash due to missing initialization Ralf Baechle
@ 2008-09-27 16:30 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-09-27 16:30 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-ide, linux-mips
On Sunday 21 September 2008, Ralf Baechle wrote:
> If things are just right this will result in the hws[0]->parent being
> passed to ide_host_add() being non-zero and an ooops a little later.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
thanks, applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-27 17:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-21 20:47 [PATCH] Swarm: Fix crash due to missing initialization Ralf Baechle
2008-09-27 16:30 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).